Issue 14508: Interest propagation bugfix.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14508: Interest propagation bugfix. (Closed)

Created:
12 years ago by Christian Plesner Hansen

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Visibility:
Public.

Description

Fixed bug in interest propagation caused by following the loop edge out of a loop choice node before the continuation edge.

Patch Set 1 #

Total comments: 1

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+61 lines, -7 lines)			Patch
M	src/jsregexp.h	View	3 chunks	+20 lines, -1 line	0 comments	Download
M	src/jsregexp.cc	View	5 chunks	+40 lines, -5 lines	1 comment	Download
M	test/cctest/test-regexp.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

12 years ago (2008-12-17 13:14:41 UTC) #2

LGTM

http://codereview.chromium.org/14508/diff/1/2
File src/jsregexp.cc (right):

http://codereview.chromium.org/14508/diff/1/2#newcode2693
Line 2693: //   [if r >= f] \----> ...
Someone should build this in wrought iron and you could use it as an "Irregexp
Christmas tree".

Expand Messages | Collapse Messages