Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Issue 145073009: Revert of Add <link rel=next> support to prerender. (Closed)

Created:
6 years, 10 months ago by Lei Zhang
Modified:
6 years, 10 months ago
CC:
chromium-reviews, tburkard+watch_chromium.org, gavinp+prer_chromium.org, cbentzel+watch_chromium.org, dominich+watch_chromium.org, davidben+watch_chromium.org
Visibility:
Public.

Description

Revert of Add <link rel=next> support to prerender. (https://codereview.chromium.org/113803003/) Reason for revert: Linux ASAN Tests (2) run 22831 failed with leaks in the RelNextByFieldTrial test. Original issue's description: > Add <link rel=next> support to prerender. > > IEs prerender implementation supports rel=next link elements. Let's > also parse them, and based on a field trial launch these as > prerenders. > > R=davidben,tburkard,jochen,jschuh@chromium.org > BUG=329963 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250280 TBR=davidben@google.com,jochen@chromium.org,tburkard@chromium.org,davidben@chromium.org,jschuh@chromium.org+,jschuh@chromium.org,gavinp@chromium.org NOTREECHECKS=true NOTRY=true BUG=329963 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250299

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -117 lines) Patch
M chrome/browser/prerender/prerender_link_manager.h View 4 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/prerender/prerender_link_manager.cc View 8 chunks +3 lines, -34 lines 0 comments Download
M chrome/browser/prerender/prerender_message_filter.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/prerender/prerender_message_filter.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/prerender/prerender_unittest.cc View 8 chunks +13 lines, -43 lines 0 comments Download
M chrome/chrome_common.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/prerender_messages.h View 1 chunk +1 line, -6 lines 0 comments Download
D chrome/common/prerender_types.h View 1 chunk +0 lines, -19 lines 0 comments Download
M chrome/renderer/prerender/prerender_dispatcher.cc View 2 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lei Zhang
Created Revert of Add <link rel=next> support to prerender.
6 years, 10 months ago (2014-02-11 02:44:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/145073009/1
6 years, 10 months ago (2014-02-11 02:46:14 UTC) #2
commit-bot: I haz the power
6 years, 10 months ago (2014-02-11 02:48:24 UTC) #3
Message was sent while issue was closed.
Change committed as 250299

Powered by Google App Engine
This is Rietveld 408576698