Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: build/gyp_chromium

Issue 145073004: Support joined -D flags for gn. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/gyp_chromium
diff --git a/build/gyp_chromium b/build/gyp_chromium
index fd162eaf0ca51fbcf621ae592fe06988548b2bdb..c6e23d3e62dc7edfd719f67a163293a71379dd78 100755
--- a/build/gyp_chromium
+++ b/build/gyp_chromium
@@ -121,8 +121,11 @@ def GetGypVarsForGN(supplemental_files):
# to ignore all arguments other than "-D".
cmdline_input_items = []
for i in range(len(sys.argv))[1:]:
- if sys.argv[i] == '-D' and i + 1 < len(sys.argv):
- cmdline_input_items += [sys.argv[i + 1]]
+ if sys.argv[i].startswith('-D'):
+ if sys.argv[i] == '-D' and i + 1 < len(sys.argv):
+ cmdline_input_items += [sys.argv[i + 1]]
+ elif len(sys.argv[i]) > 2:
+ cmdline_input_items += [sys.argv[i][2:]]
cmdline_items = ProcessGypDefinesItems(cmdline_input_items)
return dict(supp_items + env_items + cmdline_items)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698