Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 145073004: Support joined -D flags for gn. (Closed)

Created:
6 years, 11 months ago by Nico
Modified:
6 years, 11 months ago
Reviewers:
tfarina, brettw
CC:
chromium-reviews
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M build/gyp_chromium View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nico
Please let me know if this works for you.
6 years, 11 months ago (2014-01-22 18:00:53 UTC) #1
tfarina
Apparently, yes, it works. I ran the following command lines: $ g cl patch 145073004 ...
6 years, 11 months ago (2014-01-23 02:16:12 UTC) #2
Nico
Brett, Ima tbr you since you're away atm.
6 years, 11 months ago (2014-01-23 03:08:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/145073004/1
6 years, 11 months ago (2014-01-23 03:09:31 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-23 09:55:51 UTC) #5
Message was sent while issue was closed. 
Change committed as 246558

Powered by Google App Engine
This is Rietveld 408576698