Issue 14506: Fixed constant calculation that's not allowed on windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14506: Fixed constant calculation that's not allowed on windows. (Closed)

Created:
12 years ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
mads.ager, Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Description

Changed (1<<31)-1 into INT_MAX.

Patch Set 1 #

Total comments: 1

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	src/ast.h	View		3 chunks	+4 lines, -2 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

12 years ago (2008-12-17 12:00:48 UTC) #2

LGTM

http://codereview.chromium.org/14506/diff/1/2
File src/ast.h (right):

http://codereview.chromium.org/14506/diff/1/2#newcode31
Line 31: #include <limits.h>
Remove this and use kMaxInt from globals.h?

Expand Messages | Collapse Messages