Issue 1450533002: Revert of Enabling included files when reloading local NTP with --local-ntp-reload.

Issue 1450533002: Revert of Enabling included files when reloading local NTP with --local-ntp-reload. (Closed)

Created:
5 years, 1 month ago by loyso (OOO)

Modified:
5 years, 1 month ago

Reviewers:
Mathieu, tmartino, fserb

CC:
chromium-reviews, David Black, dhollowa+watch_chromium.org, donnd+watch_chromium.org, dougw+watch_chromium.org, Jered, jfweitz+watch_chromium.org, kelvinp, kmadhusu+watch_chromium.org, melevin+watch_chromium.org, samarth+watch_chromium.org, skanuj+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert of Enabling included files when reloading local NTP with --local-ntp-reload. (patchset #9 id:160001 of https://codereview.chromium.org/1376243005/ ) Reason for revert: Fails iOS build. ../third_party/re2/re2/re2.h:186:10: fatal error: 're2/stringpiece.h' file not found #include "re2/stringpiece.h" ^ 1 error generated. Original issue's description: > Enabling included files when reloading local NTP with --local-ntp-reload. > > Committed: https://crrev.com/5788cd432cc28372aa85a57cd7a66e6b6699db74 > Cr-Commit-Position: refs/heads/master@{#359357} > > Committed: https://crrev.com/9eafb7d4f9b985163c30354e1c7e34a9b447c275 > Cr-Commit-Position: refs/heads/master@{#359650} TBR=fserb@chromium.org,mathp@chromium.org,tmartino@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/374a357e8eca60427a1d3907027614781af02db1 Cr-Commit-Position: refs/heads/master@{#359653}

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -64 lines)			Patch
M	chrome/browser/search/local_files_ntp_source.h	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/search/local_files_ntp_source.cc	View	4 chunks	+1 line, -59 lines	0 comments	Download
M	chrome/browser/search/local_ntp_source.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

loyso (OOO)

Created Revert of Enabling included files when reloading local NTP with --local-ntp-reload.

5 years, 1 month ago (2015-11-13 21:57:55 UTC) #1

loyso (OOO)

Description was changed from ========== Revert of Enabling included files when reloading local NTP with ...

5 years, 1 month ago (2015-11-13 21:58:50 UTC) #2

Description was changed from

==========
Revert of Enabling included files when reloading local NTP with
--local-ntp-reload. (patchset #9 id:160001 of
https://codereview.chromium.org/1376243005/ )

Reason for revert:
CompileC
/b/build/slave/iOS_Device/build/src/xcodebuild/chrome.build/Release-iphoneos/browser.build/Objects-normal/armv7/local_files_ntp_source.o
browser/search/local_files_ntp_source.cc normal armv7 c++
com.apple.compilers.llvm.clang.1_0.compiler
    cd /b/build/slave/iOS_Device/build/src/chrome
    export LANG=en_US.US-ASCII
    export
PATH="/Applications/Xcode7.0.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/usr/bin:/Applications/Xcode7.0.app/Contents/Developer/usr/bin:/Users/chrome-bot/slavebin:/b/depot_tools:/usr/local/git/bin:/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin"
   
/b/build/slave/iOS_Device/build/src/chrome/../third_party/llvm-build/Release+Asserts/bin/clang
-x c++ -arch armv7 -fmessage-length=0 -fdiagnostics-show-note-include-stack
-fmacro-backtrace-limit=0 -std=c++11 -stdlib=libc++ -Wno-trigraphs
-fno-exceptions -fno-rtti -Os -Werror -Wno-missing-field-initializers
-Wno-missing-prototypes -Wno-return-type -Wno-non-virtual-dtor
-Wno-overloaded-virtual -Wno-exit-time-destructors -Wno-missing-braces
-Wparentheses -Wswitch -Wno-unused-function -Wno-unused-label
-Wno-unused-parameter -Wno-unused-variable -Wunused-value -Wno-empty-body
-Wno-uninitialized -Wno-unknown-pragmas -Wno-shadow -Wno-four-char-constants
-Wno-conversion -Wno-constant-conversion -Wno-int-conversion
-Wno-bool-conversion -Wno-enum-conversion -Wno-shorten-64-to-32 -Wnewline-eof
-Wno-c++11-extensions -DV8_DEPRECATION_WARNINGS -DCLD_VERSION=2 -DDISABLE_NACL
-DCHROMIUM_BUILD -DCR_CLANG_REVISION=247874-1 -DUSE_LIBJPEG_TURBO=1
-DENABLE_CONFIGURATION_POLICY -DDONT_EMBED_BUILD_METADATA
-DFIELDTRIAL_TESTING_ENABLED -DDISABLE_FTP_SUPPORT=1
-DV8_USE_EXTERNAL_STARTUP_DATA -DUSE_SYSTEM_LIBXML -DMOJO_USE_SYSTEM_IMPL
-DPROTOBUF_USE_DLLS -DGOOGLE_PROTOBUF_NO_RTTI
-DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DNO_NSPR_10_SUPPORT -DNSPR_STATIC
-DNSS_STATIC -DNSS_USE_STATIC_LIBS -DUSE_UTIL_DIRECTLY -DSK_SUPPORT_GPU=0
-DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_IGNORE_GL_TEXTURE_TARGET
-DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION
-DUSE_LIBPCI=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG
-DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DNS_BLOCK_ASSERTIONS=1
-D_FORTIFY_SOURCE=2 -isysroot
/Applications/Xcode7.0.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS9.0.sdk
-fstrict-aliasing -Wdeprecated-declarations -Winvalid-offsetof
-miphoneos-version-min=7.0 -g -fvisibility=hidden -fvisibility-inlines-hidden
-fno-threadsafe-statics -Wno-sign-conversion
-I/b/build/slave/iOS_Device/build/src/xcodebuild/Release-iphoneos/include
-I/b/build/slave/iOS_Device/build/src/xcodebuild/DerivedSources/Release -I..
-I/b/build/slave/iOS_Device/build/src/xcodebuild/chrome.build/DerivedSources/Release
-I../skia/config
-I/Applications/Xcode7.0.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS9.0.sdk/usr/include/libxml2
-I../third_party/khronos -I../gpu
-I/b/build/slave/iOS_Device/build/src/xcodebuild/DerivedSources/Release/protoc_out
-I../third_party/protobuf -I../third_party/protobuf/src
-I../third_party/dom_distiller_js/dist/proto_gen
-I/b/build/slave/iOS_Device/build/src/xcodebuild/DerivedSources/Release/chrome
-I/b/build/slave/iOS_Device/build/src/xcodebuild/DerivedSources/Release/components/strings
-I../third_party/WebKit -I../third_party/nss/nspr/pr/include
-I../third_party/nss/nspr/lib/ds -I../third_party/nss/nspr/lib/libc/include
-I../third_party/nss/nss/lib/base -I../third_party/nss/nss/lib/certdb
-I../third_party/nss/nss/lib/certhigh -I../third_party/nss/nss/lib/cryptohi
-I../third_party/nss/nss/lib/dev -I../third_party/nss/nss/lib/freebl
-I../third_party/nss/nss/lib/freebl/ecl -I../third_party/nss/nss/lib/nss
-I../third_party/nss/nss/lib/pk11wrap -I../third_party/nss/nss/lib/pkcs7
-I../third_party/nss/nss/lib/pki -I../third_party/nss/nss/lib/smime
-I../third_party/nss/nss/lib/softoken -I../third_party/nss/nss/lib/util
-I../third_party/nss/nss/lib/ckfw/builtins -I../third_party/skia/include/core
-I../third_party/skia/include/effects -I../third_party/skia/include/pdf
-I../third_party/skia/include/gpu -I../third_party/skia/include/lazy
-I../third_party/skia/include/pathops -I../third_party/skia/include/pipe
-I../third_party/skia/include/ports -I../third_party/skia/include/utils
-I../skia/ext -I../third_party/cacheinvalidation/overrides
-I../third_party/cacheinvalidation/src
-I../third_party/cacheinvalidation/google/cacheinvalidation
-I../third_party/icu/source/i18n -I../third_party/icu/source/common
-I../third_party/zlib
-I/b/build/slave/iOS_Device/build/src/xcodebuild/DerivedSources/Release/ui/resources
-I/b/build/slave/iOS_Device/build/src/xcodebuild/DerivedSources/Release/policy
-I/b/build/slave/iOS_Device/build/src/xcodebuild/chrome.build/Release-iphoneos/browser.build/DerivedSources/armv7
-I/b/build/slave/iOS_Device/build/src/xcodebuild/chrome.build/Release-iphoneos/browser.build/DerivedSources
-Wall -Wendif-labels -Wextra -Wno-unused-parameter
-Wno-missing-field-initializers -Wno-selector-type-mismatch -Wheader-hygiene
-Wno-char-subscripts -Wno-unneeded-internal-declaration
-Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing
-Wno-deprecated-register -Wno-inconsistent-missing-override
-Wno-shift-negative-value -Wno-bitfield-width -Wexit-time-destructors
-F/b/build/slave/iOS_Device/build/src/xcodebuild/Release-iphoneos -Xclang -load
-Xclang
/b/build/slave/iOS_Device/build/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib
-Xclang -add-plugin -Xclang find-bad-constructs -Xclang
-plugin-arg-find-bad-constructs -Xclang check-templates -MMD -MT dependencies
-MF
/b/build/slave/iOS_Device/build/src/xcodebuild/chrome.build/Release-iphoneos/browser.build/Objects-normal/armv7/local_files_ntp_source.d
--serialize-diagnostics
/b/build/slave/iOS_Device/build/src/xcodebuild/chrome.build/Release-iphoneos/browser.build/Objects-normal/armv7/local_files_ntp_source.dia
-c
/b/build/slave/iOS_Device/build/src/chrome/browser/search/local_files_ntp_source.cc
-o
/b/build/slave/iOS_Device/build/src/xcodebuild/chrome.build/Release-iphoneos/browser.build/Objects-normal/armv7/local_files_ntp_source.o
In file included from
/b/build/slave/iOS_Device/build/src/chrome/browser/search/local_files_ntp_source.cc:21:
../third_party/re2/re2/re2.h:186:10: fatal error: 're2/stringpiece.h' file not
found
#include "re2/stringpiece.h"
         ^
1 error generated.

** BUILD FAILED **


The following build commands failed:
	CompileC
/b/build/slave/iOS_Device/build/src/xcodebuild/chrome.build/Release-iphoneos/browser.build/Objects-normal/armv7/local_files_ntp_source.o
browser/search/local_files_ntp_source.cc normal armv7 c++
com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)


Original issue's description:
> Enabling included files when reloading local NTP with --local-ntp-reload.
> 
> Committed: https://crrev.com/5788cd432cc28372aa85a57cd7a66e6b6699db74
> Cr-Commit-Position: refs/heads/master@{#359357}
> 
> Committed: https://crrev.com/9eafb7d4f9b985163c30354e1c7e34a9b447c275
> Cr-Commit-Position: refs/heads/master@{#359650}

TBR=fserb@chromium.org,mathp@chromium.org,tmartino@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
==========

to

==========
Revert of Enabling included files when reloading local NTP with
--local-ntp-reload. (patchset #9 id:160001 of
https://codereview.chromium.org/1376243005/ )

Reason for revert:

Fails the build.

../third_party/re2/re2/re2.h:186:10: fatal error: 're2/stringpiece.h' file not
found
#include "re2/stringpiece.h"
         ^
1 error generated.

** BUILD FAILED **


The following build commands failed:
	CompileC
/b/build/slave/iOS_Device/build/src/xcodebuild/chrome.build/Release-iphoneos/browser.build/Objects-normal/armv7/local_files_ntp_source.o
browser/search/local_files_ntp_source.cc normal armv7 c++
com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)


Original issue's description:
> Enabling included files when reloading local NTP with --local-ntp-reload.
> 
> Committed: https://crrev.com/5788cd432cc28372aa85a57cd7a66e6b6699db74
> Cr-Commit-Position: refs/heads/master@{#359357}
> 
> Committed: https://crrev.com/9eafb7d4f9b985163c30354e1c7e34a9b447c275
> Cr-Commit-Position: refs/heads/master@{#359650}

TBR=fserb@chromium.org,mathp@chromium.org,tmartino@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
==========

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1450533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1450533002/1

5 years, 1 month ago (2015-11-13 21:59:28 UTC) #3

loyso (OOO)

Description was changed from ========== Revert of Enabling included files when reloading local NTP with ...

5 years, 1 month ago (2015-11-13 22:00:18 UTC) #4

Description was changed from

==========
Revert of Enabling included files when reloading local NTP with
--local-ntp-reload. (patchset #9 id:160001 of
https://codereview.chromium.org/1376243005/ )

Reason for revert:

Fails the build.

../third_party/re2/re2/re2.h:186:10: fatal error: 're2/stringpiece.h' file not
found
#include "re2/stringpiece.h"
         ^
1 error generated.

** BUILD FAILED **


The following build commands failed:
	CompileC
/b/build/slave/iOS_Device/build/src/xcodebuild/chrome.build/Release-iphoneos/browser.build/Objects-normal/armv7/local_files_ntp_source.o
browser/search/local_files_ntp_source.cc normal armv7 c++
com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)


Original issue's description:
> Enabling included files when reloading local NTP with --local-ntp-reload.
> 
> Committed: https://crrev.com/5788cd432cc28372aa85a57cd7a66e6b6699db74
> Cr-Commit-Position: refs/heads/master@{#359357}
> 
> Committed: https://crrev.com/9eafb7d4f9b985163c30354e1c7e34a9b447c275
> Cr-Commit-Position: refs/heads/master@{#359650}

TBR=fserb@chromium.org,mathp@chromium.org,tmartino@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
==========

to

==========
Revert of Enabling included files when reloading local NTP with
--local-ntp-reload. (patchset #9 id:160001 of
https://codereview.chromium.org/1376243005/ )

Reason for revert:

Fails iOS build.

../third_party/re2/re2/re2.h:186:10: fatal error: 're2/stringpiece.h' file not
found
#include "re2/stringpiece.h"
         ^
1 error generated.


Original issue's description:
> Enabling included files when reloading local NTP with --local-ntp-reload.
> 
> Committed: https://crrev.com/5788cd432cc28372aa85a57cd7a66e6b6699db74
> Cr-Commit-Position: refs/heads/master@{#359357}
> 
> Committed: https://crrev.com/9eafb7d4f9b985163c30354e1c7e34a9b447c275
> Cr-Commit-Position: refs/heads/master@{#359650}

TBR=fserb@chromium.org,mathp@chromium.org,tmartino@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
==========

commit-bot: I haz the power

5 years, 1 month ago (2015-11-13 22:02:35 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/374a357e8eca60427a1d3907027614781af02db1
Cr-Commit-Position: refs/heads/master@{#359653}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages