Let chrome_prefs handle Preferences initialization from master_preferences.

chrome/browser/first_run/first_run_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/memory/ref_counted.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/extensions/component_loader.h"
 #include "chrome/browser/first_run/first_run.h"
 #include "chrome/browser/importer/importer_list.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/test/base/in_process_browser_test.h"
 #include "chrome/test/base/ui_test_utils.h"
+#include "components/user_prefs/user_prefs.h"
 #include "content/public/browser/web_contents.h"
+#include "content/public/common/content_switches.h"
 #include "content/public/test/test_launcher.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 typedef InProcessBrowserTest FirstRunBrowserTest;
 
 IN_PROC_BROWSER_TEST_F(FirstRunBrowserTest, SetShowFirstRunBubblePref) {
   EXPECT_TRUE(g_browser_process->local_state()->FindPreference(
       prefs::kShowFirstRunBubbleOption));
   EXPECT_EQ(first_run::FIRST_RUN_BUBBLE_DONT_SHOW,
             g_browser_process->local_state()->GetInteger(
@@ skipping 188 matching lines @@
 IN_PROC_BROWSER_TEST_F(FirstRunMasterPrefsImportNothing,
                        MAYBE_ImportNothingAndShowNewTabPage) {
   EXPECT_EQ(first_run::AUTO_IMPORT_CALLED, first_run::auto_import_state());
   ui_test_utils::NavigateToURLWithDisposition(
       browser(), GURL(chrome::kChromeUINewTabURL), CURRENT_TAB,
       ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);
   content::WebContents* tab = browser()->tab_strip_model()->GetWebContentsAt(0);
   EXPECT_EQ(1, tab->GetMaxPageID());
 }
 
+// Test first run with some tracked preferences.
+extern const char kWithTrackedPrefs[] =
+    "{\n"
+    "  \"homepage\": \"test.com\",\n"

[erikwright (departed), 2014/02/04 20:55:28]

use example.com

[gab, 2014/02/04 22:32:11]

Done.

+    "  \"homepage_is_newtabpage\": false\n"
+    "}\n";
+// A test fixture which will run with in a first run scenario with

[erikwright (departed), 2014/02/04 20:55:28]

with in -> in

[erikwright (departed), 2014/02/04 20:55:28]

which -> that

[gab, 2014/02/04 22:32:11]

Done.

[gab, 2014/02/04 22:32:11]

Done.

+// master_preferences set to kWithTrackedPrefs. Parametrizable on the

[erikwright (departed), 2014/02/04 20:55:28]

parameterizable

[gab, 2014/02/04 22:32:11]

Done.

+// SettingsEnforcement experiment to be forced.
+class FirstRunMasterPrefsWithTrackedPreferences
+    : public FirstRunMasterPrefsBrowserTestT<kWithTrackedPrefs>,
+      public testing::WithParamInterface<std::string> {
+ public:
+  virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE {
+    FirstRunMasterPrefsBrowserTestT::SetUpCommandLine(command_line);
+    const std::string force_settings_enforcement_trial(
+        "SettingsEnforcement/" + GetParam() + "/");
+    command_line->AppendSwitchASCII(switches::kForceFieldTrials,

[erikwright (departed), 2014/02/04 20:55:28]

I'd just break after (, indent by 4 spaces, and inline
force_settings_enforcement_trial

[gab, 2014/02/04 22:32:11]

Done.

+                                    force_settings_enforcement_trial);
+  }
+};

[erikwright (departed), 2014/02/04 20:55:28]

blank line after };

[gab, 2014/02/04 22:32:11]

Done.

+IN_PROC_BROWSER_TEST_P(FirstRunMasterPrefsWithTrackedPreferences,
+                       TrackedPreferencesSurviveFirstRun) {
+  const PrefService* user_prefs = browser()->profile()->GetPrefs();
+  std::string tmp;

[erikwright (departed), 2014/02/04 20:55:28]

tmp is unused

[gab, 2014/02/04 22:32:11]

Oops, got too used to the DictionaryValue::Get interface :) -- turns out
PrefService doesn't need an out-param for its getters!

+  EXPECT_EQ("test.com", user_prefs->GetString(prefs::kHomePage));
+  EXPECT_FALSE(user_prefs->GetBoolean(prefs::kHomePageIsNewTabPage));

[erikwright (departed), 2014/02/04 20:55:28]

Can you add a test that the default is true, or something?

[gab, 2014/02/04 22:32:11]

Done.

+}
+
+INSTANTIATE_TEST_CASE_P(FirstRunMasterPrefsWithTrackedPreferencesInstance,
+                        FirstRunMasterPrefsWithTrackedPreferences,
+                        testing::Values("no_enforcement",
+                                        "enforce",
+                                        "enforce_no_seeding",
+                                        "enforce_no_seeding_no_migration"));
+
 #endif  // !defined(OS_CHROMEOS)