Let chrome_prefs handle Preferences initialization from master_preferences.

chrome/browser/first_run/first_run.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_FIRST_RUN_FIRST_RUN_H_
 #define CHROME_BROWSER_FIRST_RUN_FIRST_RUN_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 142 matching lines @@
 // decision of making chrome default browser in post import tasks.
 void DoPostImportTasks(Profile* profile, bool make_chrome_default_for_user);
 
 // Returns the current state of AutoImport as recorded in a bitfield formed from
 // values in AutoImportState.
 uint16 auto_import_state();
 
 // Set a master preferences file path that overrides platform defaults.
 void SetMasterPrefsPathForTesting(const base::FilePath& master_prefs);
 
-// The master preferences is a JSON file with the same entries as the
+// The master_preferences is a JSON file with the same entries as the
 // 'Default\Preferences' file. This function locates this file from a standard
-// location and processes it so it becomes the default preferences in the
-// profile pointed to by |user_data_dir|. After processing the file, the
-// function returns a value from the ProcessMasterPreferencesResult enum,
-// indicating whether the first run flow should be shown, skipped, or whether
-// the browser should exit.
+// location, processes it, and hands it to ProfileImpl so it becomes the default

[erikwright (departed), 2014/02/04 20:55:28]

I find "hands it to ProfileImpl" to be an implementation detail.

[gab, 2014/02/04 22:32:11]

Done.

+// preferences in the profile pointed to by |user_data_dir|. After processing
+// the file, this function returns a value from the
+// ProcessMasterPreferencesResult enum, indicating whether the first run flow
+// should be shown, skipped, or whether the browser should exit.
 //
-// This function destroys any existing prefs file and it is meant to be
-// invoked only on first run.
+// This function overwrites any existing Preferences file and is only meant to
+// be invoked on first run.
 //
 // See chrome/installer/util/master_preferences.h for a description of
 // 'master_preferences' file.
 ProcessMasterPreferencesResult ProcessMasterPreferences(
     const base::FilePath& user_data_dir,
     MasterPrefs* out_prefs);
 
 }  // namespace first_run
 
 #endif  // CHROME_BROWSER_FIRST_RUN_FIRST_RUN_H_