src/core/SkWriteBuffer.cpp - Issue 145053003: Have peek32 return uint32_t& to make it harder to look at more than 4 bytes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkWriteBuffer.cpp

Issue 145053003: Have peek32 return uint32_t& to make it harder to look at more than 4 bytes. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: read write at 32 Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/core/SkWriteBuffer.cpp

diff --git a/src/core/SkWriteBuffer.cpp b/src/core/SkWriteBuffer.cpp

index a295a8c88c2b05be4e8c28eb4a445e3788dc2c9b..07e8252ed8a8c5800c46ba3b81d4fa415f94ab80 100644

--- a/src/core/SkWriteBuffer.cpp

+++ b/src/core/SkWriteBuffer.cpp

@@ -321,5 +321,5 @@ void SkWriteBuffer::writeFlattenable(const SkFlattenable* flattenable) {

flattenable->flatten(*this);

uint32_t objSize = fWriter.bytesWritten() - offset;

// record the obj's size

- *fWriter.peek32(offset - sizeof(uint32_t)) = objSize;

+ fWriter.write32At(offset - sizeof(uint32_t), objSize);

}

« no previous file with comments | « src/core/SkPictureRecord.cpp ('k') | tests/Writer32Test.cpp » ('j') | no next file with comments »