Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 1450513002: Revert of Update testing frameworks/tests for MDB (Closed)

Created:
5 years, 1 month ago by egdaniel
Modified:
5 years, 1 month ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Update testing frameworks/tests for MDB (patchset #4 id:60001 of https://codereview.chromium.org/1441533003/ ) Reason for revert: Speculative revert for leaks based on ASAN bot (and some local valgrind testing) Original issue's description: > Update testing frameworks/tests for MDB > > This CL: > > Fixes an ordering problem w.r.t. drawTarget clean up in GrContext::abandonContext (for text test that abandons context) > Fixes when the lastDrawTarget field is set on a RenderTarget (now in GrDrawTarget ctor) due to GrTestTarget use case > Updates the ProgramUnitTest to use multiple drawTargets > Adds renderTarget creation to GrTestTargets (in MDB drawTargets require them) > > BUG=skia:4094 > > Committed: https://skia.googlesource.com/skia/+/9c8605144a0f15e3e69a4e1dcd5d3e63f339380e TBR=joshualitt@chromium.org,joshualitt@google.com,robertphillips@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4094 Committed: https://skia.googlesource.com/skia/+/1d5127327111e00d0e4530adae73b11ad2ee3f42

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -56 lines) Patch
M src/gpu/GrContext.cpp View 1 chunk +2 lines, -5 lines 0 comments Download
M src/gpu/GrDrawContext.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/GrDrawingManager.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrDrawingManager.cpp View 3 chunks +4 lines, -17 lines 0 comments Download
M src/gpu/GrTest.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/gpu/GrTest.cpp View 2 chunks +3 lines, -18 lines 0 comments Download
M tests/GLProgramsTest.cpp View 4 chunks +9 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
egdaniel
Created Revert of Update testing frameworks/tests for MDB
5 years, 1 month ago (2015-11-13 21:42:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1450513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1450513002/1
5 years, 1 month ago (2015-11-13 21:42:50 UTC) #2
commit-bot: I haz the power
5 years, 1 month ago (2015-11-13 21:42:59 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1d5127327111e00d0e4530adae73b11ad2ee3f42

Powered by Google App Engine
This is Rietveld 408576698