Issue 14505: * Changed simplified index-of to use correct BMH algorithm, for a theoretical better performance.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14505: * Changed simplified index-of to use correct BMH algorithm, for a theoretical better performance. (Closed)

Created:
12 years ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Visibility:
Public.

Description

Minor changes, mostly cosmetic, in string search.

Patch Set 1 #

Total comments: 1

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -17 lines)			Patch
	M	src/runtime.cc	View		6 chunks	+18 lines, -17 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

12 years ago (2008-12-17 09:07:18 UTC) #2

LGTM

http://codereview.chromium.org/14505/diff/1/2
File src/runtime.cc (right):

http://codereview.chromium.org/14505/diff/1/2#newcode1172
Line 1172: int last_char_shift = m - 1 - CharOccurence<schar, pchar>(last_char);
Noun. occurence. Common misspelling of occurrence.

Expand Messages | Collapse Messages