Roll sdk dependency to 34357cdad108dcba734949bd13bd28c76ea285e0

pkg/fletchc/lib/src/enqueuer_mixin.dart

Index: pkg/fletchc/lib/src/enqueuer_mixin.dart
diff --git a/pkg/fletchc/lib/src/enqueuer_mixin.dart b/pkg/fletchc/lib/src/enqueuer_mixin.dart
index c404a8813d3e665416c4d2adc0023e4d9894933b..ea97ed10cda4f757dae06b39e8e4438cc8810b5e 100644
--- a/pkg/fletchc/lib/src/enqueuer_mixin.dart
+++ b/pkg/fletchc/lib/src/enqueuer_mixin.dart
@@ -8,7 +8,7 @@ part of fletchc.fletch_enqueuer;
 
 get notImplemented => throw "not implemented";
 
-class EnqueuerMixin {
+class EnqueuerMixin implements CodegenEnqueuer {

[ahe, 2015/11/17 16:44:09]

Not sure about this.

[sigurdm, 2015/11/19 14:33:47]

Ok, lets discuss it.
My idea was to get warnings if CodegenEnqueuer adds more methods that we want to
implement

   String get name => notImplemented;
 
   Compiler get compiler => notImplemented;
@@ -52,7 +52,7 @@ class EnqueuerMixin {
 
   Set<Element> get newlyEnqueuedElements => notImplemented;
 
-  Set<UniverseSelector> get newlySeenSelectors => notImplemented;
+  Set<DynamicUse> get newlySeenSelectors => notImplemented;
 
   bool get enabledNoSuchMethod => notImplemented;
   set enabledNoSuchMethod(bool value) => notImplemented;
@@ -67,7 +67,6 @@ class EnqueuerMixin {
 
   void registerInstantiatedType(
       InterfaceType type,
-      Registry registry,
       {bool mirrorUsage: false}) => notImplemented;
 
   bool checkNoEnqueuedInvokedInstanceMethods() => notImplemented;
@@ -84,11 +83,11 @@ class EnqueuerMixin {
 
   void processInstantiatedClass(ClassElement cls) => notImplemented;
 
-  void registerInvocation(UniverseSelector selector) => notImplemented;
+  void registerInvocation(DynamicUse use) => notImplemented;
 
-  void registerInvokedGetter(UniverseSelector selector) => notImplemented;
+  void registerInvokedGetter(DynamicUse use) => notImplemented;
 
-  void registerInvokedSetter(UniverseSelector selector) => notImplemented;
+  void registerInvokedSetter(DynamicUse use) => notImplemented;
 
   bool shouldIncludeElementDueToMirrors(
       Element element,
@@ -131,19 +130,19 @@ class EnqueuerMixin {
   processInstanceFunctions(String n, bool f(Element e)) => notImplemented;
 
   void handleUnseenSelector(
-      UniverseSelector universeSelector) => notImplemented;
+      DynamicUse use) => notImplemented;
 
-  void registerStaticUse(Element element) => notImplemented;
+  void registerStaticUse(StaticUse element) => notImplemented;
 
   void registerGetOfStaticFunction(FunctionElement element) => notImplemented;
 
-  void registerDynamicInvocation(UniverseSelector selector) => notImplemented;
+  void registerDynamicInvocation(DynamicUse use) => notImplemented;
 
-  void registerSelectorUse(UniverseSelector universeSelector) => notImplemented;
+  void registerSelectorUse(DynamicUse use) => notImplemented;
 
-  void registerDynamicGetter(UniverseSelector selector) => notImplemented;
+  void registerDynamicGetter(DynamicUse use) => notImplemented;
 
-  void registerDynamicSetter(UniverseSelector selector) => notImplemented;
+  void registerDynamicSetter(DynamicUse use) => notImplemented;
 
   void registerGetterForSuperMethod(Element element) => notImplemented;
 
@@ -154,20 +153,16 @@ class EnqueuerMixin {
   void registerIsCheck(DartType type) => notImplemented;
 
   void registerCallMethodWithFreeTypeVariables(
-      Element element,
-      Registry registry) => notImplemented;
+      Element element) => notImplemented;
 
   void registerClosurizedMember(
-      TypedElement element,
-      Registry registry) => notImplemented;
+      TypedElement element) => notImplemented;
 
   void registerClosureIfFreeTypeVariables(
-      TypedElement element,
-      Registry registry) => notImplemented;
+      TypedElement element) => notImplemented;
 
   void registerClosure(
-      LocalFunctionElement element,
-      Registry registry) => notImplemented;
+      LocalFunctionElement element) => notImplemented;
 
   void forEach(void f(WorkItem work)) => notImplemented;
 
@@ -176,4 +171,31 @@ class EnqueuerMixin {
   void logSummary(log(message)) => notImplemented;
 
   void forgetElement(Element element) => notImplemented;
+
+  @override

[ahe, 2015/11/17 16:44:09]

Please don't use @override, or use it consistently.

[sigurdm, 2015/11/19 14:33:47]

I tried to use it consistently in the code I added.
This CL is already very big, and it is supposed to be the smallest sensible
change that makes the roll work.

That said I'm happy to add it to the rest of the methods.

+  void handleUnseenSelectorInternal(DynamicUse dynamicUse) => notImplemented;
+
+  @override
+  bool isClassProcessed(ClassElement cls) => notImplemented;
+
+  @override
+  Iterable<ClassElement> get processedClasses => notImplemented;
+
+  @override
+  void registerDynamicUse(DynamicUse dynamicUse) => notImplemented;
+
+  @override
+  void registerStaticUseInternal(StaticUse staticUse) => notImplemented;
+
+  @override
+  void registerTypeUse(TypeUse typeUse) => notImplemented;
+
+  @override
+  DiagnosticReporter get reporter => notImplemented;
+
+  @override
+  Resolution get resolution => notImplemented;
+
+  @override
+  EnqueuerStrategy get strategy => notImplemented;
 }