pkg/fletchc/lib/src/closure_environment.dart - Issue 1450393002: Roll sdk dependency to 34357cdad108dcba734949bd13bd28c76ea285e0

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/fletchc/lib/src/closure_environment.dart

Issue 1450393002: Roll sdk dependency to 34357cdad108dcba734949bd13bd28c76ea285e0 (Closed) Base URL: git@github.com:dart-lang/fletch.git@master

Patch Set: Address ahe's review Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/fletchc/lib/src/closure_environment.dart

diff --git a/pkg/fletchc/lib/src/closure_environment.dart b/pkg/fletchc/lib/src/closure_environment.dart

index aeb4f593cde33502422d7b2d49ef51a2a1ee4076..1172a8179ce86eb571df2a2e6aa6c47bcd4608f3 100644

--- a/pkg/fletchc/lib/src/closure_environment.dart

+++ b/pkg/fletchc/lib/src/closure_environment.dart

@@ -746,10 +746,9 @@ class ClosureVisitor

node, indexFunction, indexSetFunction, index, operator, null);

}

- @override

void visitTypeAnnotation(TypeAnnotation node) {

- // This is to avoid the inherited implementation that visits children and

- // throws when encountering anything unresolved.

+ // TODO(sigurdm): This is to avoid the inherited implementation that visits

+ // children and throws when encountering anything unresolved.

}

void handleImmutableLocalSet(

« no previous file with comments | « pkg/fletchc/lib/fletch_compiler.dart ('k') | pkg/fletchc/lib/src/codegen_visitor.dart » ('j') | no next file with comments »