Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: pkg/fletchc/lib/src/codegen_visitor.dart

Issue 1450393002: Roll sdk dependency to 34357cdad108dcba734949bd13bd28c76ea285e0 (Closed) Base URL: git@github.com:dart-lang/fletch.git@master
Patch Set: Update status files Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« pkg/fletchc/lib/src/closure_environment.dart ('K') | « pkg/fletchc/lib/src/closure_environment.dart ('k') | pkg/fletchc/lib/src/constructor_codegen.dart » ('j') | pkg/fletchc/lib/src/debug_registry.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/fletchc/lib/src/codegen_visitor.dart
diff --git a/pkg/fletchc/lib/src/codegen_visitor.dart b/pkg/fletchc/lib/src/codegen_visitor.dart
index cfb1da327fa0693a0b51de7a4fa6a7d6e33daea4..3dfd86273921363f68e28834cc786853b8b02aa7 100644
--- a/pkg/fletchc/lib/src/codegen_visitor.dart
+++ b/pkg/fletchc/lib/src/codegen_visitor.dart
@@ -20,18 +20,26 @@ import 'package:compiler/src/constants/expressions.dart' show
ConstructedConstantExpression,
TypeConstantExpression;
-import 'package:compiler/src/dart2jslib.dart' show
- MessageKind,
- Registry;
+import 'package:compiler/src/resolution/tree_elements.dart' show
+ TreeElements;
import 'package:compiler/src/util/util.dart' show
Link;
+import 'package:compiler/src/common/names.dart' show
+ Names,
+ Selectors;
+
+import 'package:compiler/src/universe/use.dart' show DynamicUse, StaticUse;
+
import 'package:compiler/src/elements/elements.dart';
-import 'package:compiler/src/resolution/resolution.dart';
import 'package:compiler/src/tree/tree.dart';
-import 'package:compiler/src/universe/universe.dart';
-import 'package:compiler/src/util/util.dart' show Spannable;
+import 'package:compiler/src/universe/call_structure.dart' show
+ CallStructure;
+import 'package:compiler/src/universe/selector.dart' show
+ Selector;
+import 'package:compiler/src/diagnostics/spannable.dart' show
+ Spannable;
import 'package:compiler/src/dart_types.dart';
import 'fletch_context.dart';
@@ -39,7 +47,6 @@ import 'fletch_context.dart';
import 'fletch_backend.dart';
import 'fletch_constants.dart' show
- FletchFunctionBuilderConstant,
FletchClassConstant,
FletchClassInstanceConstant;
@@ -210,7 +217,8 @@ abstract class CodegenVisitor
ConstructorBulkMixin,
InitializerBulkMixin,
BaseImplementationOfStaticsMixin,
- BaseImplementationOfLocalsMixin
+ BaseImplementationOfLocalsMixin,
+ SetIfNullBulkMixin
implements SemanticSendVisitor, SemanticDeclarationVisitor {
// A literal int can have up to 31 bits of information (32 minus sign).
static const int LITERAL_INT_MAX = 0x3FFFFFFF;
@@ -223,8 +231,6 @@ abstract class CodegenVisitor
final ExecutableElement element;
- final MemberElement member;
-
final FletchFunctionBuilder functionBuilder;
final Map<Element, LocalValue> scope = <Element, LocalValue>{};
@@ -367,13 +373,9 @@ abstract class CodegenVisitor
scope.remove(local);
}
- void registerDynamicInvocation(Selector selector);
-
- void registerDynamicGetter(Selector selector);
+ void registerDynamicUse(Selector selector);
- void registerDynamicSetter(Selector selector);
-
- void registerStaticInvocation(FunctionElement function);
+ void registerStaticUse(StaticUse use);
ahe 2015/12/01 10:12:12 StaticUse (like DynamicUse) is problematic to use
sigurdm 2015/12/03 14:48:09 Done.
void registerInstantiatedClass(ClassElement klass);
@@ -389,7 +391,7 @@ abstract class CodegenVisitor
int compileLazyFieldInitializer(FieldElement field);
void invokeMethod(Node node, Selector selector) {
- registerDynamicInvocation(selector);
+ registerDynamicUse(selector);
String symbol = context.getSymbolFromSelector(selector);
int id = context.getSymbolId(symbol);
int arity = selector.argumentCount;
@@ -397,17 +399,17 @@ abstract class CodegenVisitor
assembler.invokeMethod(fletchSelector, arity, selector.name);
}
- void invokeGetter(Node node, Selector selector) {
- registerDynamicGetter(selector);
- String symbol = context.getSymbolFromSelector(selector);
+ void invokeGetter(Node node, Name name) {
+ registerDynamicUse(new Selector.getter(name));
ahe 2015/12/01 10:12:12 This shouldn't create new objects.
sigurdm 2015/12/03 14:48:09 Done.
+ String symbol = context.mangleName(name);
int id = context.getSymbolId(symbol);
int fletchSelector = FletchSelector.encodeGetter(id);
assembler.invokeMethod(fletchSelector, 0);
}
- void invokeSetter(Node node, Selector selector) {
- registerDynamicSetter(selector);
- String symbol = context.getSymbolFromSelector(selector);
+ void invokeSetter(Node node, Name name) {
+ registerDynamicUse(new Selector.setter(name));
ahe 2015/12/01 10:12:12 Ditto.
sigurdm 2015/12/03 14:48:09 Done.
+ String symbol = context.mangleName(name);
int id = context.getSymbolId(symbol);
int fletchSelector = FletchSelector.encodeSetter(id);
assembler.invokeMethod(fletchSelector, 1);
@@ -449,7 +451,8 @@ abstract class CodegenVisitor
}
FletchFunctionBase requireFunction(FunctionElement element) {
- registerStaticInvocation(element);
+ // TODO(johnniwinther): More precise use.
+ registerStaticUse(new StaticUse.foreignUse(element));
ahe 2015/12/01 10:12:12 Ditto.
sigurdm 2015/12/03 14:48:09 Done.
return context.backend.getFunctionForElement(element);
}
@@ -457,7 +460,7 @@ abstract class CodegenVisitor
ConstructorElement constructor) {
assert(constructor.isGenerativeConstructor);
registerInstantiatedClass(constructor.enclosingClass);
- registerStaticInvocation(constructor);
+ registerStaticUse(new StaticUse.foreignUse(constructor));
ahe 2015/12/01 10:12:12 Ditto.
sigurdm 2015/12/03 14:48:09 Done.
return context.backend.getConstructorInitializerFunction(constructor);
}
@@ -909,7 +912,7 @@ abstract class CodegenVisitor
TypedefType typedefType = type;
int arity = typedefType.element.functionSignature.parameterCount;
int fletchSelector = context.toFletchIsSelector(
- context.backend.compiler.functionClass, arity);
+ context.backend.compiler.coreClasses.functionClass, arity);
assembler.invokeTest(fletchSelector, 0);
return;
}
@@ -1001,7 +1004,7 @@ abstract class CodegenVisitor
void doMainCall(Send node, NodeList arguments) {
FunctionElement function = context.compiler.mainFunction;
- if (function.isErroneous) {
+ if (function.isMalformed) {
doCompileError();
return;
}
@@ -1075,7 +1078,7 @@ abstract class CodegenVisitor
}
void doSuperCall(Node node, FunctionElement function) {
- registerStaticInvocation(function);
+ registerStaticUse(new StaticUse.foreignUse(function));
ahe 2015/12/01 10:12:12 Ditto.
sigurdm 2015/12/03 14:48:09 Done.
int arity = function.functionSignature.parameterCount + 1;
FletchFunctionBase base = requireFunction(function);
int constId = functionBuilder.allocateConstantFromFunction(base.functionId);
@@ -1292,14 +1295,6 @@ abstract class CodegenVisitor
NodeList arguments,
Selector selector,
_) {
- if (selector == null) {
- // TODO(ajohnsen): Remove hack - dart2js has a problem with generating
- // selectors in initializer bodies.
- selector = new Selector.call(
- node.selector.asIdentifier().source,
- element.library,
- arguments.slowLength());
- }
visitForValue(receiver);
for (Node argument in arguments) {
visitForValue(argument);
@@ -1308,6 +1303,23 @@ abstract class CodegenVisitor
applyVisitState();
}
+ void visitIfNull(
+ Send node,
+ Node left,
+ Node right,
+ _) {
+ BytecodeLabel end = new BytecodeLabel();
+ visitForValue(left);
+ assembler.dup();
+ assembler.loadLiteralNull();
+ assembler.identicalNonNumeric();
+ assembler.branchIfFalse(end);
+ assembler.pop();
+ visitForValue(right);
+ assembler.bind(end);
+ applyVisitState();
+ }
+
void doIfNotNull(Node receiver, void ifNotNull()) {
BytecodeLabel end = new BytecodeLabel();
visitForValue(receiver);
@@ -1338,13 +1350,13 @@ abstract class CodegenVisitor
Send node,
Expression receiver,
NodeList arguments,
- Selector selector,
+ CallStructure callStructure,
_) {
visitForValue(receiver);
for (Node argument in arguments) {
visitForValue(argument);
}
- invokeMethod(node, selector);
+ invokeMethod(node, new Selector.call(Names.call, callStructure));
applyVisitState();
}
@@ -1361,7 +1373,7 @@ abstract class CodegenVisitor
// statically known - that is not always the case. Implement VM support?
Element target = elements[node];
if (target != null && target.isField) {
- invokeGetter(node, new Selector.getter(target.name, element.library));
+ invokeGetter(node, new Name(target.name, element.library));
selector = new Selector.callClosureFrom(selector);
}
for (Node argument in arguments) {
@@ -1396,16 +1408,9 @@ abstract class CodegenVisitor
void visitDynamicPropertyGet(
Send node,
Node receiver,
- Selector selector,
+ Name name,
_) {
- if (selector == null) {
- // TODO(ajohnsen): Remove hack - dart2js has a problem with generating
- // selectors in initializer bodies.
- selector = new Selector.getter(
- node.selector.asIdentifier().source,
- element.library);
- }
- if (selector.name == "runtimeType") {
+ if (name.text == "runtimeType") {
// TODO(ahe): Implement runtimeType.
generateUnimplementedError(
node,
@@ -1414,38 +1419,38 @@ abstract class CodegenVisitor
return;
}
visitForValue(receiver);
- invokeGetter(node, selector);
+ invokeGetter(node, name);
applyVisitState();
}
void visitIfNotNullDynamicPropertyGet(
Send node,
Node receiver,
- Selector selector,
+ Name name,
_) {
doIfNotNull(receiver, () {
- invokeGetter(node, selector);
+ invokeGetter(node, name);
});
applyVisitState();
}
void visitThisPropertyGet(
Send node,
- Selector selector,
+ Name name,
_) {
loadThis();
- invokeGetter(node, selector);
+ invokeGetter(node, name);
applyVisitState();
}
void visitThisPropertySet(
Send node,
- Selector selector,
+ Name name,
Node rhs,
_) {
loadThis();
visitForValue(rhs);
- invokeSetter(node, selector);
+ invokeSetter(node, name);
applyVisitState();
}
@@ -1474,36 +1479,37 @@ abstract class CodegenVisitor
applyVisitState();
}
- void visitAssert(Send node, Node expression, _) {
+ void visitAssert(Assert node) {
// TODO(ajohnsen): Emit assert in checked mode.
}
void visitDynamicPropertySet(
Send node,
Node receiver,
- Selector selector,
+ Name name,
Node rhs,
_) {
visitForValue(receiver);
visitForValue(rhs);
- invokeSetter(node, selector);
+ invokeSetter(node, name);
applyVisitState();
}
void visitIfNotNullDynamicPropertySet(
SendSet node,
Node receiver,
- Selector selector,
+ Name name,
Node rhs,
_) {
doIfNotNull(receiver, () {
visitForValue(rhs);
- invokeSetter(node, selector);
+ invokeSetter(node, name);
});
applyVisitState();
}
- void doStaticFieldSet(FieldElement field) {
+ void doStaticFieldSet(
ahe 2015/12/01 10:12:12 Why this change?
sigurdm 2015/12/03 14:48:09 Not sure - reverted.
+ FieldElement field) {
int index = context.getStaticFieldIndex(field, element);
assembler.storeStatic(index);
}
@@ -1530,13 +1536,12 @@ abstract class CodegenVisitor
}
void visitStringInterpolation(StringInterpolation node) {
- // TODO(ajohnsen): Cache these in context/backend.
- Selector toString = new Selector.call('toString', null, 0);
+ // TODO(ajohnsen): Cache this in context/backend.
Selector concat = new Selector.binaryOperator('+');
visitForValueNoDebugInfo(node.string);
for (StringInterpolationPart part in node.parts) {
visitForValue(part.expression);
- invokeMethod(part.expression, toString);
+ invokeMethod(part.expression, Selectors.toString_);
LiteralString string = part.string;
if (string.dartString.isNotEmpty) {
visitForValueNoDebugInfo(string);
@@ -1551,7 +1556,7 @@ abstract class CodegenVisitor
if (visitState == VisitState.Value) {
assembler.loadLiteralNull();
} else if (visitState == VisitState.Test) {
- assembler.branch(falseLabel);
+ if (falseLabel != null) assembler.branch(falseLabel);
}
}
@@ -1598,7 +1603,7 @@ abstract class CodegenVisitor
assembler.loadLiteral(value);
}
} else if (visitState == VisitState.Test) {
- assembler.branch(falseLabel);
+ if (falseLabel != null) assembler.branch(falseLabel);
}
}
@@ -1606,7 +1611,7 @@ abstract class CodegenVisitor
if (visitState == VisitState.Value) {
assembler.loadConst(allocateConstantFromNode(node));
} else if (visitState == VisitState.Test) {
- assembler.branch(falseLabel);
+ if (falseLabel != null) assembler.branch(falseLabel);
}
}
@@ -1625,7 +1630,8 @@ abstract class CodegenVisitor
// Call with empty arguments, as we call the default constructor.
callConstructor(
node, constructor, new NodeList.empty(), CallStructure.NO_ARGS);
- Selector add = new Selector.call('add', null, 1);
+ Selector add = new Selector.call(new Name('add', null),
+ CallStructure.ONE_ARG);
for (Node element in node.elements) {
assembler.dup();
visitForValue(element);
@@ -1642,8 +1648,9 @@ abstract class CodegenVisitor
applyVisitState();
return;
}
- ClassElement literalClass = context.backend.mapImplementation;
- ConstructorElement constructor = literalClass.lookupDefaultConstructor();
+ ClassElement literalClass =
+ context.backend.mapImplementation.implementation;
+ ConstructorElement constructor = literalClass.lookupConstructor("");
if (constructor == null) {
internalError(literalClass, "Failed to lookup default map constructor");
return;
@@ -1888,82 +1895,74 @@ abstract class CodegenVisitor
void doDynamicPropertyCompound(
Node node,
+ Name name,
AssignmentOperator operator,
- Node rhs,
- Selector getterSelector,
- Selector setterSelector) {
+ Node rhs) {
// Dup receiver for setter.
assembler.dup();
- invokeGetter(node, getterSelector);
+ invokeGetter(node, name);
visitForValue(rhs);
invokeMethod(node, getAssignmentSelector(operator));
- invokeSetter(node, setterSelector);
+ invokeSetter(node, name);
}
void visitDynamicPropertyCompound(
Send node,
Node receiver,
+ Name name,
AssignmentOperator operator,
Node rhs,
- Selector getterSelector,
- Selector setterSelector,
_) {
visitForValue(receiver);
doDynamicPropertyCompound(
node,
+ name,
operator,
- rhs,
- getterSelector,
- setterSelector);
+ rhs);
applyVisitState();
}
void visitIfNotNullDynamicPropertyCompound(
Send node,
Node receiver,
+ Name name,
AssignmentOperator operator,
Node rhs,
- Selector getterSelector,
- Selector setterSelector,
_) {
doIfNotNull(receiver, () {
doDynamicPropertyCompound(
node,
+ name,
operator,
- rhs,
- getterSelector,
- setterSelector);
+ rhs);
});
applyVisitState();
}
void visitThisPropertyCompound(
Send node,
+ Name name,
AssignmentOperator operator,
Node rhs,
- Selector getterSelector,
- Selector setterSelector,
_) {
loadThis();
doDynamicPropertyCompound(
node,
+ name,
operator,
- rhs,
- getterSelector,
- setterSelector);
+ rhs);
applyVisitState();
}
void doDynamicPrefix(
Node node,
- IncDecOperator operator,
- Selector getterSelector,
- Selector setterSelector) {
+ Name name,
+ IncDecOperator operator) {
assembler.dup();
- invokeGetter(node, getterSelector);
+ invokeGetter(node, name);
assembler.loadLiteral(1);
invokeMethod(node, getIncDecSelector(operator));
- invokeSetter(node, setterSelector);
+ invokeSetter(node, name);
}
void doIndexPrefix(
@@ -2044,39 +2043,37 @@ abstract class CodegenVisitor
void visitThisPropertyPrefix(
Send node,
+ Name name,
IncDecOperator operator,
- Selector getterSelector,
- Selector setterSelector,
_) {
loadThis();
- doDynamicPrefix(node, operator, getterSelector, setterSelector);
+ doDynamicPrefix(node, name, operator);
applyVisitState();
}
void visitThisPropertyPostfix(
Send node,
+ Name name,
IncDecOperator operator,
- Selector getterSelector,
- Selector setterSelector,
_) {
// If visitState is for effect, we can ignore the return value, thus always
// generate code for the simpler 'prefix' case.
if (visitState == VisitState.Effect) {
loadThis();
- doDynamicPrefix(node, operator, getterSelector, setterSelector);
+ doDynamicPrefix(node, name, operator);
applyVisitState();
return;
}
loadThis();
- invokeGetter(node, getterSelector);
+ invokeGetter(node, name);
// For postfix, keep local, unmodified version, to 'return' after store.
assembler.dup();
assembler.loadLiteral(1);
invokeMethod(node, getIncDecSelector(operator));
loadThis();
assembler.loadLocal(1);
- invokeSetter(node, setterSelector);
+ invokeSetter(node, name);
assembler.popMany(2);
applyVisitState();
}
@@ -2084,24 +2081,22 @@ abstract class CodegenVisitor
void visitDynamicPropertyPrefix(
Send node,
Node receiver,
+ Name name,
IncDecOperator operator,
- Selector getterSelector,
- Selector setterSelector,
_) {
visitForValue(receiver);
- doDynamicPrefix(node, operator, getterSelector, setterSelector);
+ doDynamicPrefix(node, name, operator);
applyVisitState();
}
void visitIfNotNullDynamicPropertyPrefix(
Send node,
Node receiver,
+ Name name,
IncDecOperator operator,
- Selector getterSelector,
- Selector setterSelector,
_) {
doIfNotNull(receiver, () {
- doDynamicPrefix(node, operator, getterSelector, setterSelector);
+ doDynamicPrefix(node, name, operator);
});
applyVisitState();
}
@@ -2109,19 +2104,18 @@ abstract class CodegenVisitor
void doDynamicPostfix(
Send node,
Node receiver,
- IncDecOperator operator,
- Selector getterSelector,
- Selector setterSelector) {
+ Name name,
+ IncDecOperator operator) {
int receiverSlot = assembler.stackSize - 1;
assembler.loadSlot(receiverSlot);
- invokeGetter(node, getterSelector);
+ invokeGetter(node, name);
// For postfix, keep local, unmodified version, to 'return' after store.
assembler.dup();
assembler.loadLiteral(1);
invokeMethod(node, getIncDecSelector(operator));
assembler.loadSlot(receiverSlot);
assembler.loadLocal(1);
- invokeSetter(node, setterSelector);
+ invokeSetter(node, name);
assembler.popMany(2);
assembler.storeLocal(1);
// Pop receiver.
@@ -2131,34 +2125,32 @@ abstract class CodegenVisitor
void visitDynamicPropertyPostfix(
Send node,
Node receiver,
+ Name name,
IncDecOperator operator,
- Selector getterSelector,
- Selector setterSelector,
_) {
// If visitState is for effect, we can ignore the return value, thus always
// generate code for the simpler 'prefix' case.
if (visitState == VisitState.Effect) {
visitForValue(receiver);
- doDynamicPrefix(node, operator, getterSelector, setterSelector);
+ doDynamicPrefix(node, name, operator);
applyVisitState();
return;
}
visitForValue(receiver);
- doDynamicPostfix(node, receiver, operator, getterSelector, setterSelector);
+ doDynamicPostfix(node, receiver, name, operator);
applyVisitState();
}
void visitIfNotNullDynamicPropertyPostfix(
Send node,
Node receiver,
+ Name name,
IncDecOperator operator,
- Selector getterSelector,
- Selector setterSelector,
_) {
doIfNotNull(receiver, () {
doDynamicPostfix(
- node,receiver, operator, getterSelector, setterSelector);
+ node, receiver, name, operator);
});
applyVisitState();
}
@@ -2754,14 +2746,14 @@ abstract class CodegenVisitor
// Evalutate expression and iterator.
visitForValue(node.expression);
- invokeGetter(node.expression, new Selector.getter('iterator', null));
+ invokeGetter(node.expression, Names.iterator);
jumpInfo[node] = new JumpInfo(assembler.stackSize, start, end);
assembler.bind(start);
assembler.dup();
- invokeMethod(node, new Selector.call('moveNext', null, 0));
+ invokeMethod(node, Selectors.moveNext);
assembler.branchIfFalse(end);
bool isVariableDeclaration = node.declaredIdentifier.asSend() == null;
@@ -2770,24 +2762,24 @@ abstract class CodegenVisitor
// Create local value and load the current element to it.
LocalValue value = createLocalValueFor(element);
assembler.dup();
- invokeGetter(node, new Selector.getter('current', null));
+ invokeGetter(node, Names.current);
value.initialize(assembler);
pushVariableDeclaration(value);
} else {
if (element == null || element.isInstanceMember) {
loadThis();
assembler.loadLocal(1);
- invokeGetter(node, new Selector.getter('current', null));
+ invokeGetter(node, Names.current);
Selector selector = elements.getSelector(node.declaredIdentifier);
- invokeSetter(node, selector);
+ invokeSetter(node, selector.memberName);
} else {
assembler.dup();
- invokeGetter(node, new Selector.getter('current', null));
+ invokeGetter(node, Names.current);
if (element.isLocal) {
scope[element].store(assembler);
} else if (element.isField) {
doStaticFieldSet(element);
- } else if (element.isErroneous) {
+ } else if (element.isMalformed) {
doUnresolved(element.name);
assembler.pop();
} else {
@@ -3099,7 +3091,7 @@ abstract class CodegenVisitor
}
void internalError(Spannable spannable, String reason) {
- context.compiler.internalError(spannable, reason);
+ context.compiler.reporter.internalError(spannable, reason);
}
void generateUnimplementedError(Spannable spannable, String reason) {
@@ -3171,6 +3163,13 @@ abstract class CodegenVisitor
applyVisitState();
}
+ @override
+ void bulkHandleSetIfNull(Node node, _) {
+ generateUnimplementedError(
+ node, "[bulkHandleSetIfNull] isn't implemented.");
+ applyVisitState();
+ }
+
void previsitDeferredAccess(Send node, PrefixElement prefix, _) {
// We don't support deferred access, so nothing to do for now.
}
@@ -3201,20 +3200,12 @@ abstract class FletchRegistryMixin {
FletchRegistry get registry;
FletchContext get context;
- void registerDynamicInvocation(Selector selector) {
- registry.registerDynamicInvocation(new UniverseSelector(selector, null));
- }
-
- void registerDynamicGetter(Selector selector) {
- registry.registerDynamicGetter(new UniverseSelector(selector, null));
- }
-
- void registerDynamicSetter(Selector selector) {
- registry.registerDynamicSetter(new UniverseSelector(selector, null));
+ void registerDynamicUse(Selector selector) {
+ registry.registerDynamicUse(selector);
}
- void registerStaticInvocation(FunctionElement function) {
- registry.registerStaticInvocation(function);
+ void registerStaticUse(StaticUse staticUse) {
+ registry.registerStaticUse(staticUse);
}
void registerInstantiatedClass(ClassElement klass) {
@@ -3231,11 +3222,11 @@ abstract class FletchRegistryMixin {
void registerClosurization(FunctionElement element, ClosureKind kind) {
if (kind == ClosureKind.localFunction) {
- // TODO(ahe): Get rid of the call to [registerStaticInvocation]. It is
+ // TODO(ahe): Get rid of the call to [registerStaticUse]. It is
// currently needed to ensure that local function expression closures are
// compiled correctly. For example, `[() {}].last()`, notice that `last`
// is a getter. This happens for both named and unnamed.
- registerStaticInvocation(element);
+ registerStaticUse(new StaticUse.foreignUse(element));
}
registry.registerClosurization(element, kind);
}
« pkg/fletchc/lib/src/closure_environment.dart ('K') | « pkg/fletchc/lib/src/closure_environment.dart ('k') | pkg/fletchc/lib/src/constructor_codegen.dart » ('j') | pkg/fletchc/lib/src/debug_registry.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698