Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 1450373002: Add a Binding class to manager the binding of a message pipe. (Closed)

Created:
5 years, 1 month ago by qsr
Modified:
5 years, 1 month ago
Reviewers:
ppi
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add a Binding class to manager the binding of a message pipe. R=ppi@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/091c678187cd1cd2a3480ede0d4b9b5ce92ace99

Patch Set 1 #

Total comments: 10

Patch Set 2 : Follow review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -9 lines) Patch
M mojo/public/java/bindings/src/org/chromium/mojo/bindings/Interface.java View 1 4 chunks +43 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
qsr
5 years, 1 month ago (2015-11-17 12:19:48 UTC) #1
ppi
lgtm % nits https://codereview.chromium.org/1450373002/diff/1/mojo/public/java/bindings/src/org/chromium/mojo/bindings/Interface.java File mojo/public/java/bindings/src/org/chromium/mojo/bindings/Interface.java (right): https://codereview.chromium.org/1450373002/diff/1/mojo/public/java/bindings/src/org/chromium/mojo/bindings/Interface.java#newcode311 mojo/public/java/bindings/src/org/chromium/mojo/bindings/Interface.java:311: * The |Binding| objects enables managing ...
5 years, 1 month ago (2015-11-17 12:38:38 UTC) #2
qsr
https://codereview.chromium.org/1450373002/diff/1/mojo/public/java/bindings/src/org/chromium/mojo/bindings/Interface.java File mojo/public/java/bindings/src/org/chromium/mojo/bindings/Interface.java (right): https://codereview.chromium.org/1450373002/diff/1/mojo/public/java/bindings/src/org/chromium/mojo/bindings/Interface.java#newcode311 mojo/public/java/bindings/src/org/chromium/mojo/bindings/Interface.java:311: * The |Binding| objects enables managing the bindings from ...
5 years, 1 month ago (2015-11-17 12:49:54 UTC) #3
qsr
5 years, 1 month ago (2015-11-17 13:27:58 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
091c678187cd1cd2a3480ede0d4b9b5ce92ace99 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698