Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 145033014: Enable media android tests. (Closed)

Created:
6 years, 11 months ago by shadi
Modified:
6 years, 11 months ago
Reviewers:
dtu
CC:
chromium-reviews, chrome-speed-team+watch_google.com
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Enable media android tests and make --disable-gesture-requirement-for-media-playback default for media measurement. Issues with nexus 4 and 7 are not repro-ing. Plus with earlier changes to media actions, tests should skip when video error happens instead of marking the bot red. BUG=329691 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247106

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase tot #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -19 lines) Patch
M tools/perf/benchmarks/media.py View 1 3 chunks +0 lines, -19 lines 0 comments Download
M tools/perf/measurements/media.py View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
shadi
PTAL https://codereview.chromium.org/145033014/diff/1/tools/perf/benchmarks/media.py File tools/perf/benchmarks/media.py (left): https://codereview.chromium.org/145033014/diff/1/tools/perf/benchmarks/media.py#oldcode72 tools/perf/benchmarks/media.py:72: # Disable MSE tests on windows 8 crbug.com/330910 ...
6 years, 11 months ago (2014-01-24 19:29:19 UTC) #1
dtu
lgtm
6 years, 11 months ago (2014-01-24 22:51:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shadi@chromium.org/145033014/1
6 years, 11 months ago (2014-01-25 00:10:00 UTC) #3
commit-bot: I haz the power
Failed to apply patch for tools/perf/benchmarks/media.py: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 11 months ago (2014-01-25 00:10:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shadi@chromium.org/145033014/70001
6 years, 11 months ago (2014-01-25 00:26:08 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=251749
6 years, 11 months ago (2014-01-25 01:32:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shadi@chromium.org/145033014/70001
6 years, 11 months ago (2014-01-25 01:47:03 UTC) #7
commit-bot: I haz the power
6 years, 11 months ago (2014-01-25 09:17:38 UTC) #8
Message was sent while issue was closed.
Change committed as 247106

Powered by Google App Engine
This is Rietveld 408576698