Issue 145033012: Make ServiceWorkerVersion::{Start,Stop}Worker take callback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 145033012: Make ServiceWorkerVersion::{Start,Stop}Worker take callback (Closed)

Created:
6 years, 11 months ago by kinuko

Modified:
6 years, 10 months ago

Reviewers:
alecflett

CC:
chromium-reviews, tzik, jam, nhiroki, joi+watch-content_chromium.org, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+watch

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Make ServiceWorkerVersion::{Start,Stop}Worker take callback Also adds content_browsertests for start & stop flow BUG=313530 TEST=content_browsertests:ServiceWorkerBrowserTest.\* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247380

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+332 lines, -58 lines)			Patch
M	content/browser/service_worker/service_worker_browsertest.cc	View	9 chunks	+171 lines, -39 lines	0 comments	Download
M	content/browser/service_worker/service_worker_version.h	View	4 chunks	+41 lines, -8 lines	0 comments	Download
M	content/browser/service_worker/service_worker_version.cc	View	2 chunks	+120 lines, -11 lines	0 comments	Download

Total messages: 5 (0 generated)

kinuko

Removed the install-related part from the old CL. I assume we'll have ServiceWorkerVersion::Install(callback) or something ...

6 years, 11 months ago (2014-01-24 10:08:05 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/145033012/220001

6 years, 10 months ago (2014-01-27 22:43:19 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/145033012/220001

6 years, 10 months ago (2014-01-28 00:12:47 UTC) #4

Message was sent while issue was closed.

Change committed as 247380