Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1955)

Issue 145033010: Add a suppressions file for leak sanitizer. (Closed)

Created:
6 years, 11 months ago by mtklein
Modified:
6 years, 11 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Add a suppressions file for leak sanitizer. LeakSanitizer is built into AddressSanitizer, and runs with no extra speed penalty. Most interestingly, it's got a lock-free allocator, so it doesn't bottleneck threaded code. This file is enough to supress all leak warnings except from the Nvidia driver on my desktop for tests and dm. Looks like lsan doesn't or can't pay attention to leaked globals (-fno-common doesn't affect this). BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13153

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
A tools/lsan.supp View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mtklein
6 years, 11 months ago (2014-01-23 18:19:01 UTC) #1
robertphillips
lgtm
6 years, 11 months ago (2014-01-23 18:23:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/145033010/1
6 years, 11 months ago (2014-01-23 18:30:16 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-23 18:42:36 UTC) #4
Message was sent while issue was closed.
Change committed as 13153

Powered by Google App Engine
This is Rietveld 408576698