chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc - Issue 145033006: views: Make View::set_border() take a scoped_ptr<>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc

Issue 145033006: views: Make View::set_border() take a scoped_ptr<>. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Further renaming Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/message_center/message_center_frame_view.cc ('K') | « chrome/browser/ui/views/password_generation_bubble_view.cc ('k') | chrome/browser/ui/views/profile_chooser_view.cc » ('j') | ui/views/view.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc

diff --git a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc

index fff8e895c0a1e80b8019b8dfc54067ede569a36f..768424fbe717e39c7d2662d3c9da1928261f06bf 100644

--- a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc

+++ b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc

@@ -210,7 +210,7 @@ void ManagePasswordsBubbleView::Init() {

manage_passwords_bubble_model_,

manage_passwords_bubble_model_->pending_credentials(),

first_field_width, second_field_width);

- item->set_border(views::Border::CreateSolidSidedBorder(

+ item->SetBorder(views::Border::CreateSolidSidedBorder(

1, 0, 1, 0, GetNativeTheme()->GetSystemColor(

ui::NativeTheme::kColorId_EnabledMenuButtonBorderColor)));

layout->AddView(item);

@@ -267,11 +267,11 @@ void ManagePasswordsBubbleView::Init() {

manage_passwords_bubble_model_, *i->second, first_field_width,

second_field_width);

if (i == manage_passwords_bubble_model_->best_matches().begin()) {

- item->set_border(views::Border::CreateSolidSidedBorder(

+ item->SetBorder(views::Border::CreateSolidSidedBorder(

1, 0, 1, 0, GetNativeTheme()->GetSystemColor(

ui::NativeTheme::kColorId_EnabledMenuButtonBorderColor)));

} else {

- item->set_border(views::Border::CreateSolidSidedBorder(

+ item->SetBorder(views::Border::CreateSolidSidedBorder(

0, 0, 1, 0, GetNativeTheme()->GetSystemColor(

ui::NativeTheme::kColorId_EnabledMenuButtonBorderColor)));

}

@@ -292,11 +292,11 @@ void ManagePasswordsBubbleView::Init() {

manage_passwords_bubble_model_->pending_credentials(),

first_field_width, second_field_width);

if (manage_passwords_bubble_model_->best_matches().empty()) {

- item->set_border(views::Border::CreateSolidSidedBorder(1, 0, 1, 0,

+ item->SetBorder(views::Border::CreateSolidSidedBorder(1, 0, 1, 0,

GetNativeTheme()->GetSystemColor(

ui::NativeTheme::kColorId_EnabledMenuButtonBorderColor)));

} else {

- item->set_border(views::Border::CreateSolidSidedBorder(0, 0, 1, 0,

+ item->SetBorder(views::Border::CreateSolidSidedBorder(0, 0, 1, 0,

GetNativeTheme()->GetSystemColor(

ui::NativeTheme::kColorId_EnabledMenuButtonBorderColor)));

}