Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Unified Diff: chrome/browser/ui/views/autofill/autofill_dialog_views.cc

Issue 145033006: views: Make View::set_border() take a scoped_ptr<>. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Further renaming Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/autofill/autofill_dialog_views.cc
diff --git a/chrome/browser/ui/views/autofill/autofill_dialog_views.cc b/chrome/browser/ui/views/autofill/autofill_dialog_views.cc
index 912711f861bd673a79299d9356e35503bd66503a..5de1bdd41a6aa7df061d278ba1d06976951bd84c 100644
--- a/chrome/browser/ui/views/autofill/autofill_dialog_views.cc
+++ b/chrome/browser/ui/views/autofill/autofill_dialog_views.cc
@@ -166,7 +166,7 @@ void SelectComboboxValueOrSetToDefault(views::Combobox* combobox,
class SectionRowView : public views::View {
public:
SectionRowView() {
- set_border(views::Border::CreateEmptyBorder(10, 0, 0, 0));
+ SetBorder(views::Border::CreateEmptyBorder(10, 0, 0, 0));
}
virtual ~SectionRowView() {}
@@ -305,7 +305,7 @@ class NotificationView : public views::View,
set_background(
views::Background::CreateSolidBackground(data.GetBackgroundColor()));
- set_border(views::Border::CreateSolidSidedBorder(1, 0, 1, 0,
+ SetBorder(views::Border::CreateSolidSidedBorder(1, 0, 1, 0,
data.GetBorderColor()));
}
@@ -466,14 +466,14 @@ AutofillDialogViews::AccountChooser::AccountChooser(
menu_button_(new views::MenuButton(NULL, base::string16(), this, true)),
link_(new views::Link()),
delegate_(delegate) {
- set_border(views::Border::CreateEmptyBorder(0, 0, 0, 10));
+ SetBorder(views::Border::CreateEmptyBorder(0, 0, 0, 10));
SetLayoutManager(
new views::BoxLayout(views::BoxLayout::kHorizontal, 0, 0,
kAroundTextPadding));
AddChildView(image_);
menu_button_->set_background(NULL);
- menu_button_->set_border(NULL);
+ menu_button_->ClearBorder();
gfx::Insets insets = GetInsets();
menu_button_->SetFocusPainter(
views::Painter::CreateDashedFocusPainterWithInsets(insets));
@@ -591,7 +591,7 @@ void AutofillDialogViews::OverlayView::UpdateState() {
message_view_->SetEnabledColor(GetNativeTheme()->GetSystemColor(
ui::NativeTheme::kColorId_TextfieldReadOnlyColor));
- message_view_->set_border(
+ message_view_->SetBorder(
views::Border::CreateEmptyBorder(kOverlayMessageVerticalPadding,
kDialogEdgePadding,
kOverlayMessageVerticalPadding,
@@ -710,7 +710,7 @@ AutofillDialogViews::NotificationArea::NotificationArea(
: delegate_(delegate) {
// Reserve vertical space for the arrow (regardless of whether one exists).
// The -1 accounts for the border.
- set_border(views::Border::CreateEmptyBorder(kArrowHeight - 1, 0, 0, 0));
+ SetBorder(views::Border::CreateEmptyBorder(kArrowHeight - 1, 0, 0, 0));
views::BoxLayout* box_layout =
new views::BoxLayout(views::BoxLayout::kVertical, 0, 0, 0);
@@ -797,7 +797,7 @@ AutofillDialogViews::SectionContainer::SectionContainer(
forward_mouse_events_(false) {
set_notify_enter_exit_on_child(true);
- set_border(views::Border::CreateEmptyBorder(kDetailSectionVerticalPadding,
+ SetBorder(views::Border::CreateEmptyBorder(kDetailSectionVerticalPadding,
kDialogEdgePadding,
kDetailSectionVerticalPadding,
kDialogEdgePadding));
@@ -953,7 +953,7 @@ AutofillDialogViews::SuggestedButton::SuggestedButton(
views::MenuButtonListener* listener)
: views::MenuButton(NULL, base::string16(), listener, false) {
const int kFocusBorderWidth = 1;
- set_border(views::Border::CreateEmptyBorder(kMenuButtonTopInset,
+ SetBorder(views::Border::CreateEmptyBorder(kMenuButtonTopInset,
kDialogEdgePadding,
kMenuButtonBottomInset,
kFocusBorderWidth));
@@ -1032,7 +1032,7 @@ AutofillDialogViews::SuggestionView::SuggestionView(
base::string16(),
autofill_dialog)) {
// TODO(estade): Make this the correct color.
- set_border(
+ SetBorder(
views::Border::CreateSolidSidedBorder(1, 0, 0, 0, SK_ColorLTGRAY));
SectionRowView* label_container = new SectionRowView();
@@ -1668,7 +1668,7 @@ views::View* AutofillDialogViews::CreateFootnoteView() {
kDialogEdgePadding,
kDialogEdgePadding,
0));
- footnote_view_->set_border(
+ footnote_view_->SetBorder(
views::Border::CreateSolidSidedBorder(1, 0, 0, 0, kSubtleBorderColor));
footnote_view_->set_background(
views::Background::CreateSolidBackground(kShadingColor));

Powered by Google App Engine
This is Rietveld 408576698