Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5465)

Unified Diff: chrome/browser/ui/views/tabs/tab.cc

Issue 145033006: views: Make View::set_border() take a scoped_ptr<>. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase to ToT Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/tabs/tab.cc
diff --git a/chrome/browser/ui/views/tabs/tab.cc b/chrome/browser/ui/views/tabs/tab.cc
index 49d187bd65f3ea310fe4d7057c83fa8b706a8efc..fa9e9d88a2bf886462a3959999e8debd57b0c552 100644
--- a/chrome/browser/ui/views/tabs/tab.cc
+++ b/chrome/browser/ui/views/tabs/tab.cc
@@ -780,7 +780,7 @@ void Tab::Layout() {
// The height of the content of the Tab is the largest of the favicon,
// the title text and the close button graphic.
int content_height = std::max(tab_icon_size(), font_height_);
- close_button_->set_border(NULL);
+ close_button_->SetBorder(views::Border::NullBorder());
gfx::Size close_button_size(close_button_->GetPreferredSize());
content_height = std::max(content_height, close_button_size.height());
@@ -819,8 +819,8 @@ void Tab::Layout() {
int left_border = kCloseButtonHorzFuzz;
int right_border = width() - (lb.width() + close_button_size.width() +
left_border);
- close_button_->set_border(views::Border::CreateEmptyBorder(top_border,
- left_border, bottom_border, right_border));
+ close_button_->SetBorder(views::Border::CreateEmptyBorder(
+ top_border, left_border, bottom_border, right_border));
close_button_->SetPosition(gfx::Point(lb.width(), 0));
close_button_->SizeToPreferredSize();
close_button_->SetVisible(true);

Powered by Google App Engine
This is Rietveld 408576698