Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(853)

Unified Diff: chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc

Issue 145033006: views: Make View::set_border() take a scoped_ptr<>. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase to ToT Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
diff --git a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
index fff8e895c0a1e80b8019b8dfc54067ede569a36f..adb4e014b1422a84f74dc64ccaa02b60cd106aa5 100644
--- a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
+++ b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
@@ -210,8 +210,12 @@ void ManagePasswordsBubbleView::Init() {
manage_passwords_bubble_model_,
manage_passwords_bubble_model_->pending_credentials(),
first_field_width, second_field_width);
- item->set_border(views::Border::CreateSolidSidedBorder(
- 1, 0, 1, 0, GetNativeTheme()->GetSystemColor(
+ item->SetBorder(views::Border::CreateSolidSidedBorder(
+ 1,
+ 0,
+ 1,
+ 0,
+ GetNativeTheme()->GetSystemColor(
ui::NativeTheme::kColorId_EnabledMenuButtonBorderColor)));
layout->AddView(item);
@@ -267,12 +271,20 @@ void ManagePasswordsBubbleView::Init() {
manage_passwords_bubble_model_, *i->second, first_field_width,
second_field_width);
if (i == manage_passwords_bubble_model_->best_matches().begin()) {
- item->set_border(views::Border::CreateSolidSidedBorder(
- 1, 0, 1, 0, GetNativeTheme()->GetSystemColor(
+ item->SetBorder(views::Border::CreateSolidSidedBorder(
+ 1,
+ 0,
+ 1,
+ 0,
+ GetNativeTheme()->GetSystemColor(
ui::NativeTheme::kColorId_EnabledMenuButtonBorderColor)));
} else {
- item->set_border(views::Border::CreateSolidSidedBorder(
- 0, 0, 1, 0, GetNativeTheme()->GetSystemColor(
+ item->SetBorder(views::Border::CreateSolidSidedBorder(
+ 0,
+ 0,
+ 1,
+ 0,
+ GetNativeTheme()->GetSystemColor(
ui::NativeTheme::kColorId_EnabledMenuButtonBorderColor)));
}
layout->AddView(item);
@@ -292,11 +304,19 @@ void ManagePasswordsBubbleView::Init() {
manage_passwords_bubble_model_->pending_credentials(),
first_field_width, second_field_width);
if (manage_passwords_bubble_model_->best_matches().empty()) {
- item->set_border(views::Border::CreateSolidSidedBorder(1, 0, 1, 0,
+ item->SetBorder(views::Border::CreateSolidSidedBorder(
+ 1,
+ 0,
+ 1,
+ 0,
GetNativeTheme()->GetSystemColor(
ui::NativeTheme::kColorId_EnabledMenuButtonBorderColor)));
} else {
- item->set_border(views::Border::CreateSolidSidedBorder(0, 0, 1, 0,
+ item->SetBorder(views::Border::CreateSolidSidedBorder(
+ 0,
+ 0,
+ 1,
+ 0,
GetNativeTheme()->GetSystemColor(
ui::NativeTheme::kColorId_EnabledMenuButtonBorderColor)));
}
« no previous file with comments | « chrome/browser/ui/views/password_generation_bubble_view.cc ('k') | chrome/browser/ui/views/profile_chooser_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698