Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4145)

Unified Diff: chrome/browser/ui/views/notifications/balloon_view_views.cc

Issue 145033006: views: Make View::set_border() take a scoped_ptr<>. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase to ToT Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/new_avatar_button.cc ('k') | chrome/browser/ui/views/omnibox/omnibox_view_views.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/notifications/balloon_view_views.cc
diff --git a/chrome/browser/ui/views/notifications/balloon_view_views.cc b/chrome/browser/ui/views/notifications/balloon_view_views.cc
index 29248ca5380cb27a407759cf56871aed9ffb0f83..551a68198d93edafc8a9d24f196013b82c9a70e8 100644
--- a/chrome/browser/ui/views/notifications/balloon_view_views.cc
+++ b/chrome/browser/ui/views/notifications/balloon_view_views.cc
@@ -94,8 +94,10 @@ BalloonViewImpl::BalloonViewImpl(BalloonCollection* collection)
// We're owned by Balloon and don't want to be deleted by our parent View.
set_owned_by_client();
- set_border(new views::BubbleBorder(views::BubbleBorder::FLOAT,
- views::BubbleBorder::NO_SHADOW, SK_ColorWHITE));
+ SetBorder(scoped_ptr<views::Border>(
+ new views::BubbleBorder(views::BubbleBorder::FLOAT,
+ views::BubbleBorder::NO_SHADOW,
+ SK_ColorWHITE)));
}
BalloonViewImpl::~BalloonViewImpl() {
@@ -366,7 +368,7 @@ void BalloonViewImpl::Show(Balloon* balloon) {
options_menu_button_->SetPushedIcon(*rb.GetImageSkiaNamed(
IDR_BALLOON_WRENCH_P));
options_menu_button_->set_alignment(views::TextButton::ALIGN_CENTER);
- options_menu_button_->set_border(NULL);
+ options_menu_button_->SetBorder(views::Border::NullBorder());
options_menu_button_->SetBoundsRect(GetOptionsButtonBounds());
source_label_->SetFontList(rb.GetFontList(ui::ResourceBundle::SmallFont));
« no previous file with comments | « chrome/browser/ui/views/new_avatar_button.cc ('k') | chrome/browser/ui/views/omnibox/omnibox_view_views.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698