chrome/browser/ui/libgtk2ui/gtk2_ui.cc - Issue 145033006: views: Make View::set_border() take a scoped_ptr<>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/libgtk2ui/gtk2_ui.cc

Issue 145033006: views: Make View::set_border() take a scoped_ptr<>. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase to ToT Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/libgtk2ui/gtk2_ui.cc

diff --git a/chrome/browser/ui/libgtk2ui/gtk2_ui.cc b/chrome/browser/ui/libgtk2ui/gtk2_ui.cc

index 1ae080f809992c9a08f3ecf787232b6124c448cd..0b2809453885a6efce07d6b7db6cc775ecbe79a0 100644

--- a/chrome/browser/ui/libgtk2ui/gtk2_ui.cc

+++ b/chrome/browser/ui/libgtk2ui/gtk2_ui.cc

@@ -527,10 +527,11 @@ gfx::Image Gtk2UI::GetIconForContentType(

return gfx::Image(image_skia);

}

-views::Border* Gtk2UI::CreateNativeBorder(

+scoped_ptr<views::Border> Gtk2UI::CreateNativeBorder(

views::CustomButton* owning_button,

- views::Border* border) {

- return new Gtk2Border(this, owning_button, border);

+ scoped_ptr<views::Border> border) {

+ return scoped_ptr<views::Border>(

+ new Gtk2Border(this, owning_button, border.Pass()));

}

void Gtk2UI::AddWindowButtonOrderObserver(