Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: ui/views/border.cc

Issue 145033006: views: Make View::set_border() take a scoped_ptr<>. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase to ToT Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « ui/views/border.h ('k') | ui/views/bubble/bubble_delegate.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/views/border.h" 5 #include "ui/views/border.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/memory/scoped_ptr.h" 8 #include "base/memory/scoped_ptr.h"
9 #include "ui/gfx/canvas.h" 9 #include "ui/gfx/canvas.h"
10 #include "ui/views/painter.h" 10 #include "ui/views/painter.h"
(...skipping 115 matching lines...) Expand 10 before | Expand all | Expand 10 after
126 126
127 } // namespace 127 } // namespace
128 128
129 Border::Border() { 129 Border::Border() {
130 } 130 }
131 131
132 Border::~Border() { 132 Border::~Border() {
133 } 133 }
134 134
135 // static 135 // static
136 Border* Border::CreateSolidBorder(int thickness, SkColor color) { 136 scoped_ptr<Border> Border::NullBorder() {
137 return new SolidBorder(thickness, color); 137 return scoped_ptr<Border>();
138 } 138 }
139 139
140 // static 140 // static
141 Border* Border::CreateEmptyBorder(int top, int left, int bottom, int right) { 141 scoped_ptr<Border> Border::CreateSolidBorder(int thickness, SkColor color) {
142 return new EmptyBorder(top, left, bottom, right); 142 return scoped_ptr<Border>(new SolidBorder(thickness, color));
143 } 143 }
144 144
145 // static 145 // static
146 Border* Border::CreateSolidSidedBorder(int top, 146 scoped_ptr<Border> Border::CreateEmptyBorder(int top,
147 int left, 147 int left,
148 int bottom, 148 int bottom,
149 int right, 149 int right) {
150 SkColor color) { 150 return scoped_ptr<Border>(new EmptyBorder(top, left, bottom, right));
151 return new SidedSolidBorder(top, left, bottom, right, color);
152 } 151 }
153 152
154 // static 153 // static
155 Border* Border::CreateBorderPainter(Painter* painter, 154 scoped_ptr<Border> Border::CreateSolidSidedBorder(int top,
156 const gfx::Insets& insets) { 155 int left,
157 return new BorderPainter(painter, insets); 156 int bottom,
157 int right,
158 SkColor color) {
159 return scoped_ptr<Border>(
160 new SidedSolidBorder(top, left, bottom, right, color));
161 }
162
163 // static
164 scoped_ptr<Border> Border::CreateBorderPainter(Painter* painter,
165 const gfx::Insets& insets) {
166 return scoped_ptr<Border>(new BorderPainter(painter, insets));
158 } 167 }
159 168
160 TextButtonBorder* Border::AsTextButtonBorder() { 169 TextButtonBorder* Border::AsTextButtonBorder() {
161 return NULL; 170 return NULL;
162 } 171 }
163 172
164 const TextButtonBorder* Border::AsTextButtonBorder() const { 173 const TextButtonBorder* Border::AsTextButtonBorder() const {
165 return NULL; 174 return NULL;
166 } 175 }
167 176
168 } // namespace views 177 } // namespace views
OLDNEW
« no previous file with comments | « ui/views/border.h ('k') | ui/views/bubble/bubble_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698