Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Side by Side Diff: chrome/browser/ui/views/extensions/extension_install_dialog_view.cc

Issue 145033006: views: Make View::set_border() take a scoped_ptr<>. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase to ToT Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <vector> 5 #include <vector>
6 6
7 #include "base/basictypes.h" 7 #include "base/basictypes.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "base/i18n/rtl.h" 10 #include "base/i18n/rtl.h"
(...skipping 549 matching lines...) Expand 10 before | Expand all | Expand 10 after
560 rating->SetLayoutManager(new views::BoxLayout( 560 rating->SetLayoutManager(new views::BoxLayout(
561 views::BoxLayout::kHorizontal, 0, 0, 0)); 561 views::BoxLayout::kHorizontal, 0, 0, 0));
562 layout->AddView(rating); 562 layout->AddView(rating);
563 prompt.AppendRatingStars(AddResourceIcon, rating); 563 prompt.AppendRatingStars(AddResourceIcon, rating);
564 564
565 const gfx::FontList& small_font_list = 565 const gfx::FontList& small_font_list =
566 rb.GetFontList(ui::ResourceBundle::SmallFont); 566 rb.GetFontList(ui::ResourceBundle::SmallFont);
567 views::Label* rating_count = 567 views::Label* rating_count =
568 new views::Label(prompt.GetRatingCount(), small_font_list); 568 new views::Label(prompt.GetRatingCount(), small_font_list);
569 // Add some space between the stars and the rating count. 569 // Add some space between the stars and the rating count.
570 rating_count->set_border(views::Border::CreateEmptyBorder(0, 2, 0, 0)); 570 rating_count->SetBorder(views::Border::CreateEmptyBorder(0, 2, 0, 0));
571 rating->AddChildView(rating_count); 571 rating->AddChildView(rating_count);
572 572
573 layout->StartRow(0, column_set_id); 573 layout->StartRow(0, column_set_id);
574 views::Label* user_count = 574 views::Label* user_count =
575 new views::Label(prompt.GetUserCount(), small_font_list); 575 new views::Label(prompt.GetUserCount(), small_font_list);
576 user_count->SetAutoColorReadabilityEnabled(false); 576 user_count->SetAutoColorReadabilityEnabled(false);
577 user_count->SetEnabledColor(SK_ColorGRAY); 577 user_count->SetEnabledColor(SK_ColorGRAY);
578 layout->AddView(user_count); 578 layout->AddView(user_count);
579 579
580 layout->StartRow(0, column_set_id); 580 layout->StartRow(0, column_set_id);
(...skipping 757 matching lines...) Expand 10 before | Expand all | Expand 10 after
1338 if (slide_animation_.IsShowing()) 1338 if (slide_animation_.IsShowing())
1339 slide_animation_.Hide(); 1339 slide_animation_.Hide();
1340 else 1340 else
1341 slide_animation_.Show(); 1341 slide_animation_.Show();
1342 } 1342 }
1343 1343
1344 void ExpandableContainerView::ExpandWithoutAnimation() { 1344 void ExpandableContainerView::ExpandWithoutAnimation() {
1345 expanded_ = true; 1345 expanded_ = true;
1346 details_view_->AnimateToState(1.0); 1346 details_view_->AnimateToState(1.0);
1347 } 1347 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/dropdown_bar_view.cc ('k') | chrome/browser/ui/views/extensions/media_galleries_dialog_views.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698