Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 145033004: Convert MemoryBenchmarkingExtension to gin::Wrappable (Closed)

Created:
6 years, 11 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 11 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Convert MemoryBenchmarkingExtension to gin::Wrappable BUG=334679 R=dmikurube@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246570

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -71 lines) Patch
M content/renderer/memory_benchmarking_extension.h View 1 chunk +29 lines, -3 lines 0 comments Download
M content/renderer/memory_benchmarking_extension.cc View 1 chunk +63 lines, -62 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 2 chunks +0 lines, -6 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
6 years, 11 months ago (2014-01-22 22:07:16 UTC) #1
Dai Mikurube (NOT FULLTIME)
lgtm. thanks for working on it!
6 years, 11 months ago (2014-01-23 03:24:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/145033004/80001
6 years, 11 months ago (2014-01-23 08:11:29 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-23 11:30:07 UTC) #4
Message was sent while issue was closed.
Change committed as 246570

Powered by Google App Engine
This is Rietveld 408576698