Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 1450313002: WebRTC: Remove redundant GYP_DEFINES on iOS bots. (Closed)

Created:
5 years, 1 month ago by kjellander_chromium
Modified:
5 years, 1 month ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, stip+watch_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
build
Visibility:
Public.

Description

WebRTC: Remove redundant GYP_DEFINES on iOS bots. Remove the build_with_libjingle=1 and key_id="" since they're not needed. This aligns better with what's recommended at http://www.webrtc.org/native-code/ios This required landing https://codereview.webrtc.org/1457053003/ first. BUG=webrtc:4653 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297620

Patch Set 1 #

Patch Set 2 : Remove key_id as well #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -18 lines) Patch
M scripts/slave/recipe_modules/webrtc/chromium_config.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_ios64_debug__gn_.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_ios64_release__gn_.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_ios32_debug.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_ios32_release.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_ios32_simulator_debug.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_ios64_debug.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_ios64_release.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_ios64_simulator_debug.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_ios32_sim_dbg.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_ios64_gn_dbg.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_ios64_gn_rel.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_ios64_sim_dbg.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_ios_arm64_dbg.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_ios_arm64_rel.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_ios_dbg.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_ios_rel.json View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 28 (15 generated)
kjellander_chromium
5 years, 1 month ago (2015-11-17 07:13:13 UTC) #4
phoglund_chromium
lgtm
5 years, 1 month ago (2015-11-17 09:32:43 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1450313002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1450313002/20001
5 years, 1 month ago (2015-11-19 15:01:53 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-19 15:06:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1450313002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1450313002/20001
5 years, 1 month ago (2015-11-19 15:07:23 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: build_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/build_presubmit/builds/3124)
5 years, 1 month ago (2015-11-19 15:13:33 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1450313002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1450313002/20001
5 years, 1 month ago (2015-11-19 15:28:45 UTC) #17
commit-bot: I haz the power
Failed to request the patch to try. Please note that binary files are still unsupported ...
5 years, 1 month ago (2015-11-19 15:31:13 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1450313002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1450313002/20001
5 years, 1 month ago (2015-11-19 15:33:42 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: build_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/build_presubmit/builds/3132)
5 years, 1 month ago (2015-11-19 15:39:48 UTC) #24
kjellander_chromium
On 2015/11/19 15:39:48, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years, 1 month ago (2015-11-19 16:14:29 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1450313002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1450313002/20001
5 years, 1 month ago (2015-11-19 16:14:48 UTC) #27
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 16:20:51 UTC) #28
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=297620

Powered by Google App Engine
This is Rietveld 408576698