components/autofill/browser/webdata/autofill_table_unittest.cc - Issue 14503010: Implement WebViewDatabase's hasFormData API for chromium based webview.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/browser/webdata/autofill_table_unittest.cc

Issue 14503010: Implement WebViewDatabase's hasFormData API for chromium based webview. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix typos Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/browser/webdata/autofill_table.cc ('K') | « components/autofill/browser/webdata/autofill_table.cc ('k') | components/autofill/browser/webdata/autofill_webdata.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/browser/webdata/autofill_table_unittest.cc

diff --git a/components/autofill/browser/webdata/autofill_table_unittest.cc b/components/autofill/browser/webdata/autofill_table_unittest.cc

index b4f32646a90d61fe2cb3ed22c9385149644e4136..544f1fafc81e261329102b03b3b7507c755731a9 100644

--- a/components/autofill/browser/webdata/autofill_table_unittest.cc

+++ b/components/autofill/browser/webdata/autofill_table_unittest.cc

@@ -140,6 +140,7 @@ TEST_F(AutofillTableTest, Autofill) {

field.value = ASCIIToUTF16("Superman");

base::Time now = base::Time::Now();

base::TimeDelta two_seconds = base::TimeDelta::FromSeconds(2);

+ EXPECT_FALSE(table_->HasFormElements());

benm (inactive) 2013/04/29 18:00:03 + a test where we EXPECT_TRUE ? :)

sgurun-gerrit only 2013/04/29 19:32:39 will do. On 2013/04/29 18:00:03, benm wrote:

EXPECT_TRUE(table_->AddFormFieldValue(field, &changes));

std::vector<base::string16> v;

for (int i = 0; i < 5; i++) {