components/autofill/browser/webdata/autofill_webdata_backend.cc - Issue 14503010: Implement WebViewDatabase's hasFormData API for chromium based webview.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/browser/webdata/autofill_webdata_backend.cc

Issue 14503010: Implement WebViewDatabase's hasFormData API for chromium based webview. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address new code review Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/browser/webdata/autofill_webdata_backend.h ('k') | components/autofill/browser/webdata/autofill_webdata_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/browser/webdata/autofill_webdata_backend.cc

diff --git a/components/autofill/browser/webdata/autofill_webdata_backend.cc b/components/autofill/browser/webdata/autofill_webdata_backend.cc

index 0cda3d15310d9e4796315c7be1d2442af50caffb..e8c5fd8fdc656a8bf6c0c900e6799cb682f85f82 100644

--- a/components/autofill/browser/webdata/autofill_webdata_backend.cc

+++ b/components/autofill/browser/webdata/autofill_webdata_backend.cc

@@ -72,6 +72,14 @@ AutofillWebDataBackend::GetFormValuesForElementName(

values));

}

+scoped_ptr<WDTypedResult> AutofillWebDataBackend::HasFormElements(

+ WebDatabase* db) {

+ DCHECK(BrowserThread::CurrentlyOn(BrowserThread::DB));

+ bool value = AutofillTable::FromWebDatabase(db)->HasFormElements();

+ return scoped_ptr<WDTypedResult>(

+ new WDResult<bool>(AUTOFILL_VALUE_RESULT, value));

WebDatabase::State AutofillWebDataBackend::RemoveFormElementsAddedBetween(

const base::Time& delete_begin, const base::Time& delete_end,

WebDatabase* db) {