Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1795)

Unified Diff: android_webview/browser/aw_form_database_service.h

Issue 14503010: Implement WebViewDatabase's hasFormData API for chromium based webview. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix dep Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/browser/aw_form_database_service.h
diff --git a/android_webview/browser/aw_form_database_service.h b/android_webview/browser/aw_form_database_service.h
new file mode 100644
index 0000000000000000000000000000000000000000..07c04dee074f167204e44272991e7a453743f09f
--- /dev/null
+++ b/android_webview/browser/aw_form_database_service.h
@@ -0,0 +1,64 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef ANDROID_WEBVIEW_BROWSER_AW_FORM_DATABASE_SERVICE_H_
+#define ANDROID_WEBVIEW_BROWSER_AW_FORM_DATABASE_SERVICE_H_
+
+#include "base/basictypes.h"
+#include "base/files/file_path.h"
+#include "base/synchronization/waitable_event.h"
+#include "components/autofill/browser/webdata/autofill_webdata_service.h"
+#include "components/webdata/common/web_data_service_consumer.h"
+#include "components/webdata/common/web_database_service.h"
+
+namespace android_webview {
+
+// Handles the database operations necessary to implement the autocomplete
+// functionality. This includes creating and initializing the components that
+// handle the database backend, and providing a synchronous interface when
+// needed (the chromium database components have an async. interface).
+class AwFormDatabaseService : public WebDataServiceConsumer {
+ public:
+ AwFormDatabaseService(const base::FilePath path);
+
+ virtual ~AwFormDatabaseService();
+
+ // TODO(sgurun) Who will call this?
+ void Shutdown();
+
+ // Returns whether the form has any elements stored. May do
benm (inactive) 2013/05/07 11:16:11 do you mean whether the database has any elements
sgurun-gerrit only 2013/05/07 18:39:02 Done.
+ // IO access and block.
+ bool HasFormElements();
benm (inactive) 2013/05/07 11:16:11 Would HasFormData be a better name for symmetry wi
sgurun-gerrit only 2013/05/07 18:39:02 I think we can use "data" in android_webview/ but
benm (inactive) 2013/05/07 19:06:55 That sounds good to me.
+
+ // Clear any saved form data. Executes asynchronously.
+ void ClearFormElements();
benm (inactive) 2013/05/07 11:16:11 ClearFormData?
sgurun-gerrit only 2013/05/07 18:39:02 Done.
+
+ scoped_refptr<autofill::AutofillWebDataService>
+ get_autofill_webdata_service();
+
+ // WebDataServiceConsumer implementation.
+ virtual void OnWebDataServiceRequestDone(
+ WebDataServiceBase::Handle h,
+ const WDTypedResult* result) OVERRIDE;
+
+ private:
+ // Cancels the currently pending WebDataService query, if there is one.
+ void CancelPendingQuery();
+
+ void HasFormElementsImpl();
+
+ // Stores the query handle when an async database query is executed.
+ WebDataServiceBase::Handle pending_query_handle_;
+ bool has_form_elements_;
+ base::WaitableEvent completion_;
+
+ scoped_refptr<autofill::AutofillWebDataService> autofill_data_;
+ scoped_refptr<WebDatabaseService> web_database_;
+
+ DISALLOW_COPY_AND_ASSIGN(AwFormDatabaseService);
+};
+
+} // namespace android_webview
+
+#endif // ANDROID_WEBVIEW_BROWSER_AW_FORM_DATABASE_SERVICE_H_

Powered by Google App Engine
This is Rietveld 408576698