Implement WebViewDatabase's hasFormData API for chromium based webview.

components/autofill/browser/webdata/autofill_table.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/browser/webdata/autofill_table.h"
 
 #include <algorithm>
 #include <limits>
 #include <map>
 #include <set>
@@ skipping 445 matching lines @@
     s.BindString16(2, next_prefix);
     s.BindInt(3, limit);
   }
 
   values->clear();
   while (s.Step())
     values->push_back(s.ColumnString16(0));
   return s.Succeeded();
 }
 
+bool AutofillTable::HasFormElements() {
+  sql::Statement s(db_->GetUniqueStatement(
+      "SELECT COUNT(*) FROM autofill"));
+  if (!s.Step()) {
+    NOTREACHED();
+    return false;
+  } else {

[Ilya Sherman, 2013/04/27 00:05:55]

nit: No else stmt after a return stmt, please.

[sgurun-gerrit only, 2013/04/29 17:55:16]

Done.

[benm (inactive), 2013/04/29 18:00:03]

return s.Step() ? s.ColumnInt(0) > 0 : false;

looks quite neat. You lose the NOTREACHED though I guess.

[sgurun-gerrit only, 2013/04/29 19:32:39]

himm, notreached is used all over this file in similar circumstances. I am not
sure if we want to lose it.


On 2013/04/29 18:00:03, benm wrote:

+    return s.ColumnInt(0) > 0;
+  }
+}
+
 bool AutofillTable::RemoveFormElementsAddedBetween(
     const Time& delete_begin,
     const Time& delete_end,
     std::vector<AutofillChange>* changes) {
   DCHECK(changes);
   // Query for the pair_id, name, and value of all form elements that
   // were used between the given times.
   sql::Statement s(db_->GetUniqueStatement(
       "SELECT DISTINCT a.pair_id, a.name, a.value "
       "FROM autofill_dates ad JOIN autofill a ON ad.pair_id = a.pair_id "
@@ skipping 1593 matching lines @@
   // Add origin to credit_cards.
   if (!db_->Execute("ALTER TABLE credit_cards "
                     "ADD COLUMN origin VARCHAR DEFAULT ''")) {
       return false;
   }
 
   return transaction.Commit();
 }
 
 }  // namespace autofill