Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1450233002: Subzero: Fix a performance regression in the register allocator. (Closed)

Created:
5 years, 1 month ago by Jim Stichnoth
Modified:
5 years, 1 month ago
Reviewers:
Karl, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Fix a performance regression in the register allocator. The register allocator does not need to be considering rematerializable variables at all. When it does, there tends to be a big performance cost because the live range of a rematerializable variable tends to be large, leading to lots of expensive overlap computations against register allocation candidates. BUG= none R=jpp@chromium.org, sehr@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=4c5c57159b68c909bd4edef27c7ac09795a7f33b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M src/IceRegAlloc.cpp View 6 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Jim Stichnoth
This brings the MINIMAL=1 translation time for pnacl-llc.pexe from 6s back down to <4s.
5 years, 1 month ago (2015-11-17 01:09:26 UTC) #4
John
lgtm
5 years, 1 month ago (2015-11-17 01:10:45 UTC) #5
sehr
lgtm
5 years, 1 month ago (2015-11-17 01:11:53 UTC) #6
Jim Stichnoth
5 years, 1 month ago (2015-11-17 01:17:51 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4c5c57159b68c909bd4edef27c7ac09795a7f33b (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698