chrome/browser/translate/translate_service.cc - Issue 145023015: Introduce TranslateService and TranslateDownloadManager

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/translate/translate_service.cc

Issue 145023015: Introduce TranslateService and TranslateDownloadManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix browsertests Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/translate/translate_service.h ('K') | « chrome/browser/translate/translate_service.h ('k') | chrome/browser/translate/translate_url_util.cc » ('j') | components/translate/core/browser/translate_download_manager.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "chrome/browser/translate/translate_service.h"

	6

	7 #include "chrome/browser/browser_process.h"

	8 #include "chrome/browser/translate/translate_manager.h"

	9 #include "components/translate/core/browser/translate_download_manager.h"

	10

	11 // static

	12 void TranslateService::Initialize() {

	13 TranslateManager::GetInstance();

	14 TranslateDownloadManager::GetInstance()->set_request_context(
	blundell 2014/01/24 17:52:43 Is this class going to become more meaty in the fu Is this class going to become more meaty in the future? As it is now, it doesn't seem to have much value over inlining the calls to TranlateDownloadManager in //chrome code. droger 2014/01/27 14:13:43 Yes, it is. See the followup CL: https://coderevie Show quoted text On 2014/01/24 17:52:43, blundell wrote: > Is this class going to become more meaty in the future? As it is now, it doesn't > seem to have much value over inlining the calls to TranlateDownloadManager in > //chrome code. Yes, it is. See the followup CL: https://codereview.chromium.org/143003020/diff/80001/chrome/browser/translate...
	15 g_browser_process->system_request_context());

	16 }

	17

	18 // static

	19 void TranslateService::Shutdown(bool cleanup_pending_fetcher) {

	20 if (cleanup_pending_fetcher)

	21 TranslateManager::GetInstance()->CleanupPendingUlrFetcher();
	blundell 2014/01/24 17:52:43 Could you file a bug to rename this CleanupPending Could you file a bug to rename this CleanupPendingUrlFetcher? droger 2014/01/27 14:13:43 Why do you want to rename this? Show quoted text On 2014/01/24 17:52:43, blundell wrote: > Could you file a bug to rename this CleanupPendingUrlFetcher? Why do you want to rename this?
	22 TranslateDownloadManager::GetInstance()->set_request_context(NULL);

	23 }

OLD	NEW