Issue 145023010: Revert of Set the maximum lines number to 32 for Javascript alert message on Mac port.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 145023010: Revert of Set the maximum lines number to 32 for Javascript alert message on Mac port. (Closed)

Created:
6 years, 11 months ago by jeremy

Modified:
6 years, 11 months ago

Reviewers:
Avi (use Gerrit), yi

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

Revert of Set the maximum lines number to 32 for Javascript alert message on Mac port. (https://codereview.chromium.org/140323005/) Reason for revert: Avi is absolutely right, reverting. Original issue's description: > Set the maximum lines number to 32 for Javascript alert message on Mac port. > > BUG=331219 > R=jeremy@chromium.org > TEST=Manual test please: Launch chrome and load the popup-bug.html in BUG331219 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246457 TBR=avi@chromium.org,yi.shen@samsung.com NOTREECHECKS=true NOTRY=true BUG=331219 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246501

Created: 6 years, 11 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -15 lines)			Patch
	M	AUTHORS	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm	View		2 chunks	+0 lines, -14 lines	0 comments	Download

Total messages: 3 (0 generated)

jeremy

Created Revert of Set the maximum lines number to 32 for Javascript alert message on ...

6 years, 11 months ago (2014-01-23 03:04:54 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremy@chromium.org/145023010/1

6 years, 11 months ago (2014-01-23 03:06:46 UTC) #2

Message was sent while issue was closed.

Change committed as 246501