Issue 1450223002: Add an ApplicationConnector.Duplicate().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1450223002: Add an ApplicationConnector.Duplicate(). (Closed)

Created:
5 years, 1 month ago by viettrungluu

Modified:
5 years, 1 month ago

Reviewers:
jamesr, abarth-chromium

CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+mojopublicwatch_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Add an ApplicationConnector.Duplicate(). So those with ApplicationConnectors can spread the capability further (without having to proxy). (E.g., a thread with it can start a new thread and endow the thread with the capability, without losing the capability. Similar for a VM inside a VM.) R=jamesr@chromium.org, abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/71447c8d6a20c555aa6b0a73fbf26080db8e106e

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+100 lines, -42 lines)			Patch
M	mojo/public/interfaces/application/application_connector.mojom	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	shell/application_manager/shell_impl.h	View	2 chunks	+8 lines, -7 lines	0 comments	Download
M	shell/application_manager/shell_impl.cc	View	2 chunks	+53 lines, -24 lines	0 comments	Download
M	shell/shell_apptest.cc	View	4 chunks	+36 lines, -11 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jamesr

lgtm the lifecycle of the ApplicationConnectors is still pretty dodgy, but it's not different than ...

5 years, 1 month ago (2015-11-17 00:41:56 UTC) #2

viettrungluu

5 years, 1 month ago (2015-11-17 00:59:13 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
71447c8d6a20c555aa6b0a73fbf26080db8e106e (presubmit successful).

Expand Messages | Collapse Messages