Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1450213002: Enable PrivetV3Session without checking command line flag (Closed)

Created:
5 years, 1 month ago by Vitaly Buka (NO REVIEWS)
Modified:
5 years, 1 month ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@context7
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable PrivetV3Session without checking command line flag Network security team asked to put feature behind the flag to review the code. BUG=524788 Committed: https://crrev.com/0d9dc49cbbd262dd957f9fc447543123e1a530ab Cr-Commit-Position: refs/heads/master@{#360749}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -38 lines) Patch
M chrome/app/generated_resources.grd View 1 2 3 2 chunks +1 line, -7 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/gcd_private/gcd_private_api.cc View 3 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/gcd_private/gcd_private_apitest.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/gcd_private/privet_v3_context_getter.cc View 1 2 3 3 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/extensions/api/gcd_private/privet_v3_context_getter_unittest.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/gcd_private/privet_v3_session_unittest.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 31 (14 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1450213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1450213002/1
5 years, 1 month ago (2015-11-17 00:42:05 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1450213002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1450213002/20001
5 years, 1 month ago (2015-11-17 00:45:05 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/131620)
5 years, 1 month ago (2015-11-17 01:34:51 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1450213002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1450213002/20001
5 years, 1 month ago (2015-11-18 20:22:32 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/122397)
5 years, 1 month ago (2015-11-18 20:46:23 UTC) #10
Vitaly Buka (NO REVIEWS)
5 years, 1 month ago (2015-11-18 23:24:16 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1450213002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1450213002/40001
5 years, 1 month ago (2015-11-18 23:25:38 UTC) #14
Aleksey Shlyapnikov
lgtm
5 years, 1 month ago (2015-11-18 23:43:15 UTC) #15
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-19 01:21:44 UTC) #17
davidben
lgtm
5 years, 1 month ago (2015-11-19 23:22:08 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1450213002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1450213002/40001
5 years, 1 month ago (2015-11-20 01:29:53 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/147265) android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 1 month ago (2015-11-20 01:38:48 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1450213002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1450213002/60001
5 years, 1 month ago (2015-11-20 01:43:19 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) ios_rel_device_ninja on ...
5 years, 1 month ago (2015-11-20 03:46:46 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1450213002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1450213002/60001
5 years, 1 month ago (2015-11-20 04:54:57 UTC) #29
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 1 month ago (2015-11-20 05:00:46 UTC) #30
commit-bot: I haz the power
5 years, 1 month ago (2015-11-20 05:01:33 UTC) #31
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/0d9dc49cbbd262dd957f9fc447543123e1a530ab
Cr-Commit-Position: refs/heads/master@{#360749}

Powered by Google App Engine
This is Rietveld 408576698