Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issue 1450123006: Parse -webkit-column-rule shorthand in CSSPropertyParser with CSSParserTokens (Closed)

Created:
5 years, 1 month ago by rwlbuis
Modified:
5 years ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Parse -webkit-column-rule shorthand in CSSPropertyParser with CSSParserTokens Move -webkit-column-rule property handling from LegacyCSSPropertyParser into CSSPropertyParser. Also move its related longhands. This CL also removes the acceptQuirkyColors helper method. BUG=499780 Committed: https://crrev.com/df4d5693b0f482ff7eb1054224ef1df120190a5d Cr-Commit-Position: refs/heads/master@{#362055}

Patch Set 1 #

Patch Set 2 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -27 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 4 chunks +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp View 1 5 chunks +4 lines, -25 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
rwlbuis
PTAL.
5 years, 1 month ago (2015-11-20 14:41:14 UTC) #4
Timothy Loh
On 2015/11/20 14:41:14, rwlbuis (OOO - review only) wrote: > PTAL. lgtm
5 years, 1 month ago (2015-11-23 00:26:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1450123006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1450123006/1
5 years, 1 month ago (2015-11-23 01:22:35 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/97849)
5 years, 1 month ago (2015-11-23 01:24:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1450123006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1450123006/40001
5 years ago (2015-11-28 17:16:01 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1450123006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1450123006/40001
5 years ago (2015-11-28 17:16:46 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years ago (2015-11-28 18:27:44 UTC) #17
commit-bot: I haz the power
5 years ago (2015-11-28 18:28:33 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/df4d5693b0f482ff7eb1054224ef1df120190a5d
Cr-Commit-Position: refs/heads/master@{#362055}

Powered by Google App Engine
This is Rietveld 408576698