runtime/vm/os_thread_android.cc - Issue 1450113003: Avoid strerror_r portability issues

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/os_thread_android.cc

Issue 1450113003: Avoid strerror_r portability issues (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: oops namespace Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/os_thread_android.cc

diff --git a/runtime/vm/os_thread_android.cc b/runtime/vm/os_thread_android.cc

index f1c3a445838aef1bd2e4d965e87952340a2a63e4..f09e7f54f5ce3d760c774a67171380c20fde2733 100644

--- a/runtime/vm/os_thread_android.cc

+++ b/runtime/vm/os_thread_android.cc

@@ -11,6 +11,7 @@

#include <sys/time.h> // NOLINT

#include "platform/assert.h"

+#include "platform/utils.h"

namespace dart {

@@ -18,7 +19,7 @@ namespace dart {

if (result != 0) { \

const int kBufferSize = 1024; \

char error_message[kBufferSize]; \

- strerror_r(result, error_message, kBufferSize); \

+ Utils::StrError(result, error_message, kBufferSize); \

FATAL2("pthread error: %d (%s)", result, error_message); \

}

@@ -36,7 +37,7 @@ namespace dart {

if (result != 0) { \

const int kBufferSize = 1024; \

char error_message[kBufferSize]; \

- strerror_r(result, error_message, kBufferSize); \

+ Utils::StrError(result, error_message, kBufferSize); \

fprintf(stderr, "%s:%d: pthread error: %d (%s)\n", \

__FILE__, __LINE__, result, error_message); \

return result; \

« no previous file with comments | « runtime/platform/utils_macos.h ('k') | runtime/vm/os_thread_linux.cc » ('j') | no next file with comments »