Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 1450113002: Add use counter for history.scrollRestoration (Closed)

Created:
5 years, 1 month ago by majidvp
Modified:
5 years, 1 month ago
Reviewers:
Rick Byers
CC:
chromium-reviews, blink-reviews, vivekg, Inactive, vivekg_samsung
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add use counter for history.scrollRestoration BUG=444094 Committed: https://crrev.com/a81d7fa0f4b2e0af16149490cca05d45a4be4d39 Cr-Commit-Position: refs/heads/master@{#361052}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove comment and move up to match spec order #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M third_party/WebKit/Source/core/frame/History.idl View 1 2 chunks +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
majidvp
5 years, 1 month ago (2015-11-16 21:41:48 UTC) #2
majidvp
5 years, 1 month ago (2015-11-20 02:06:07 UTC) #4
Rick Byers
LGTM with nit, thanks! https://codereview.chromium.org/1450113002/diff/1/third_party/WebKit/Source/core/frame/History.idl File third_party/WebKit/Source/core/frame/History.idl (right): https://codereview.chromium.org/1450113002/diff/1/third_party/WebKit/Source/core/frame/History.idl#newcode45 third_party/WebKit/Source/core/frame/History.idl:45: // https://www.chromestatus.com/features/5657284784947200 unrelated nit: remove ...
5 years, 1 month ago (2015-11-20 02:59:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1450113002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1450113002/20001
5 years, 1 month ago (2015-11-20 04:17:18 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/32665)
5 years, 1 month ago (2015-11-20 04:20:17 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1450113002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1450113002/40001
5 years, 1 month ago (2015-11-22 19:45:00 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-22 21:14:02 UTC) #14
commit-bot: I haz the power
5 years, 1 month ago (2015-11-22 21:15:04 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a81d7fa0f4b2e0af16149490cca05d45a4be4d39
Cr-Commit-Position: refs/heads/master@{#361052}

Powered by Google App Engine
This is Rietveld 408576698