Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: chrome/browser/local_discovery/service_discovery_client_mac.mm

Issue 1450043002: Some services can have no IP resolved (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@context10
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/local_discovery/service_discovery_client_mac.mm
diff --git a/chrome/browser/local_discovery/service_discovery_client_mac.mm b/chrome/browser/local_discovery/service_discovery_client_mac.mm
index 3c5fbd84645965570721f8aed798689bc5eac072..7837234a6122add9bd8a38b4d68a53ae7fd11b2d 100644
--- a/chrome/browser/local_discovery/service_discovery_client_mac.mm
+++ b/chrome/browser/local_discovery/service_discovery_client_mac.mm
@@ -357,9 +357,7 @@ void ServiceResolverImplMac::NetServiceContainer::OnResolveUpdate(
}
if (service_description_.address.host().empty()) {
- NOTREACHED() << service_name_;
- // Unexpected, but could be a reason for crbug.com/513505
- base::debug::DumpWithoutCrashing();
+ VLOG(1) << "Service IP is not resolved: " << service_name_;
callback_runner_->PostTask(
FROM_HERE,
base::Bind(callback_, STATUS_KNOWN_NONEXISTENT, ServiceDescription()));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698