Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 145003019: More cleanups in remoting.gyp (Closed)

Created:
6 years, 11 months ago by Sergey Ulanov
Modified:
6 years, 11 months ago
Reviewers:
Lambros
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, weitaosu+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

More cleanups in remoting.gyp - Merged remoting_jingle_glue into remoting_protocol. - Merged remoting_host_logging and remoting_host_event_logger into remoting_host. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247102

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -158 lines) Patch
M remoting/remoting.gyp View 1 2 31 chunks +79 lines, -157 lines 0 comments Download
M remoting/remoting_android.gypi View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Sergey Ulanov
6 years, 11 months ago (2014-01-24 23:45:08 UTC) #1
Lambros
lgtm https://codereview.chromium.org/145003019/diff/1/remoting/remoting.gyp File remoting/remoting.gyp (right): https://codereview.chromium.org/145003019/diff/1/remoting/remoting.gyp#newcode326 remoting/remoting.gyp:326: 'host/daemon_process.cc', These files were Windows-only, but will now ...
6 years, 11 months ago (2014-01-25 00:31:58 UTC) #2
Sergey Ulanov
https://codereview.chromium.org/145003019/diff/1/remoting/remoting.gyp File remoting/remoting.gyp (right): https://codereview.chromium.org/145003019/diff/1/remoting/remoting.gyp#newcode326 remoting/remoting.gyp:326: 'host/daemon_process.cc', On 2014/01/25 00:31:59, Lambros wrote: > These files ...
6 years, 11 months ago (2014-01-25 01:24:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/145003019/220001
6 years, 11 months ago (2014-01-25 01:24:35 UTC) #4
commit-bot: I haz the power
Retried try job too often on android_clang_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_clang_dbg&number=109528
6 years, 11 months ago (2014-01-25 01:48:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/145003019/430001
6 years, 11 months ago (2014-01-25 02:21:32 UTC) #6
commit-bot: I haz the power
Retried try job too often on android_clang_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_clang_dbg&number=109550
6 years, 11 months ago (2014-01-25 02:51:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/145003019/610001
6 years, 11 months ago (2014-01-25 02:58:15 UTC) #8
commit-bot: I haz the power
6 years, 11 months ago (2014-01-25 08:01:33 UTC) #9
Message was sent while issue was closed.
Change committed as 247102

Powered by Google App Engine
This is Rietveld 408576698