LayoutTests/fast/text-autosizing/list-item-above-dbcat.html - Issue 145003009: Autosize list markers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/text-autosizing/list-item-above-dbcat.html

Issue 145003009: Autosize list markers. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@tot

Patch Set: Update TestExpectations. Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/TestExpectations ('k') | LayoutTests/virtual/fasttextautosizing/fast/text-autosizing/list-marker-numbered-with-autosizing-expected.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/text-autosizing/list-item-above-dbcat.html

diff --git a/LayoutTests/fast/text-autosizing/list-marker-with-links-autosizing.html b/LayoutTests/fast/text-autosizing/list-item-above-dbcat.html

similarity index 55%

copy from LayoutTests/fast/text-autosizing/list-marker-with-links-autosizing.html

copy to LayoutTests/fast/text-autosizing/list-item-above-dbcat.html

index 5e684b144ed17f514fa6750b3dbddc69dc6a3dea..e4d926485cbc7800d1fd3b46452a075ee19490fb 100644

--- a/LayoutTests/fast/text-autosizing/list-marker-with-links-autosizing.html

+++ b/LayoutTests/fast/text-autosizing/list-item-above-dbcat.html

@@ -25,13 +25,16 @@ if (window.internals) {

<body>

<div>

-The below list items should be autosized to 40px computed font-size (16 * 800/320). Also the corresponding list markers should increase in size appropriately. The whole list is shifted to the right by 8px (14 (autosized marker width) * (1 - 1/2.5) rounded) to compensate the scaling of list item markers and make sure they don't get chopped off.

+This test verifies that FastTextAutosizer considers a list item (LI) to be

+"text" for the purpose of determining the deepest block containing all text

+(DBCAT). If this were not the case, the cluster's DBCAT would be the DIV inside

+the LI, which hasn't entered layout yet when the list marker is autosized (causing

+the autosizer to crash).

</div>

-<ul>

-<li><a>List item with a link</a></li>

-<li><b>List item with bold text</b></li>

-<li>Simple plain list item</li>

-<li><a>List item with a link as part of anonymous block</a><div></div></li>

+<ul style="float:left">

+<li><div>List item list item list item list item list item list item list item

+list item list item list item list item list item list item list item list item

+list item list item list item list item list item list item list item list item</div></li>

</ul>

</body>