Issue 145003002: [DevTools] Switch from blink-based to content-based touch emulation.

Issue 145003002: [DevTools] Switch from blink-based to content-based touch emulation. (Closed)

Created:
6 years, 11 months ago by dgozman

Modified:
6 years, 8 months ago

Reviewers:
pfeldman

CC:
blink-reviews, jamesr, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, abarth-chromium, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

[DevTools] Switch from blink-based to content-based touch emulation. BUG=337142 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171859

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 5

Patch Set 5 : #

Patch Set 6 : Force layout on emulation toggle #

Patch Set 7 : fix PlatformGestureEventBuilder usage #

Patch Set 8 : AllowPinch #

Patch Set 9 : Improved pinch handling #

Patch Set 10 : rebase #

Patch Set 11 : another rebase #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+82 lines, -475 lines)			Patch
D	LayoutTests/fast/events/touch/emulate-touch-events.html	View	1 2 3 4	1 chunk	+0 lines, -112 lines	0 comments	Download
D	LayoutTests/fast/events/touch/emulate-touch-events-expected.txt	View	1 2 3 4	1 chunk	+0 lines, -63 lines	0 comments	Download
D	LayoutTests/fast/events/touch/emulated-touch-iframe.html	View	1 2 3 4	1 chunk	+0 lines, -63 lines	0 comments	Download
D	LayoutTests/fast/events/touch/emulated-touch-iframe-expected.txt	View	1 2 3 4	1 chunk	+0 lines, -8 lines	0 comments	Download
M	Source/core/frame/FrameView.cpp	View	1 2 3 4 5 6 7 8 9 10	2 chunks	+3 lines, -1 line	0 comments	Download
M	Source/core/frame/Settings.in	View	1 2 3 4 5 6 7 8 9 10	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/inspector/InspectorClient.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/inspector/InspectorPageAgent.cpp	View	1 2 3 4 5 6 7 8 9	1 chunk	+1 line, -2 lines	0 comments	Download
M	Source/core/page/EventHandler.h	View	1 2 3 4 5 6 7 8 9	2 chunks	+0 lines, -8 lines	0 comments	Download
M	Source/core/page/EventHandler.cpp	View	1 2 3 4 5 6 7 8 9 10	7 chunks	+0 lines, -208 lines	0 comments	Download
M	Source/core/page/Page.h	View	1 2 3 4 5 6 7 8 9 10	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/page/Page.cpp	View	1 2 3 4 5 6 7 8 9 10	1 chunk	+5 lines, -0 lines	0 comments	Download
M	Source/core/testing/InternalSettings.h	View	1 2 3 4 5	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/testing/InternalSettings.cpp	View	1 2 3 4 5 6 7 8 9	1 chunk	+0 lines, -6 lines	0 comments	Download
M	Source/core/testing/InternalSettings.idl	View	1 2 3 4 5	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/web/InspectorClientImpl.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/web/InspectorClientImpl.cpp	View	1 2 3 4 5 6 7 8 9 10	1 chunk	+6 lines, -0 lines	0 comments	Download
M	Source/web/WebDevToolsAgentImpl.h	View	1 2 3 4 5 6 7 8	2 chunks	+9 lines, -0 lines	0 comments	Download
M	Source/web/WebDevToolsAgentImpl.cpp	View	1 2 3 4 5 6 7 8 9 10	6 chunks	+53 lines, -0 lines	0 comments	Download
M	public/web/WebDevToolsAgentClient.h	View	1 2 3 4 5 6 7	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

dgozman

Could you please take a look? This currently works on linux aura and mac. No ...

6 years, 8 months ago (2014-04-04 15:53:38 UTC) #1

pfeldman

https://codereview.chromium.org/145003002/diff/70001/Source/web/WebDevToolsAgentImpl.cpp File Source/web/WebDevToolsAgentImpl.cpp (right): https://codereview.chromium.org/145003002/diff/70001/Source/web/WebDevToolsAgentImpl.cpp#newcode306 Source/web/WebDevToolsAgentImpl.cpp:306: FrameView* frameView = page->mainFrame()->view(); Why are these gestures handled ...

6 years, 8 months ago (2014-04-07 17:32:59 UTC) #2

pfeldman

lgtm https://codereview.chromium.org/145003002/diff/70001/Source/core/frame/FrameView.cpp File Source/core/frame/FrameView.cpp (right): https://codereview.chromium.org/145003002/diff/70001/Source/core/frame/FrameView.cpp#newcode1408 Source/core/frame/FrameView.cpp:1408: return page && page->visibilityState() != PageVisibilityStateHidden && page->focusController().isActive() ...

6 years, 8 months ago (2014-04-07 17:52:49 UTC) #3

dgozman

https://codereview.chromium.org/145003002/diff/70001/Source/core/frame/FrameView.cpp File Source/core/frame/FrameView.cpp (right): https://codereview.chromium.org/145003002/diff/70001/Source/core/frame/FrameView.cpp#newcode1408 Source/core/frame/FrameView.cpp:1408: return page && page->visibilityState() != PageVisibilityStateHidden && page->focusController().isActive() && ...

6 years, 8 months ago (2014-04-08 16:51:48 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/145003002/210001

6 years, 8 months ago (2014-04-17 14:11:36 UTC) #6

Message was sent while issue was closed.

Change committed as 171859

Expand Messages | Collapse Messages