styleguide: Allow std::move for move semantics.

styleguide: Allow std::move for move semantics.

R=danakj@chromium.org, thakis@chromium.org

Committed: https://crrev.com/f484f72276dc024e5aa15cc6901f0440ee6d7c43
Cr-Commit-Position: refs/heads/master@{#359949}

[Nico, 2015-11-16 18:47:04]

Thanks. lgtm given that lots of stuff is blocked on this.

https://codereview.chromium.org/1450013002/diff/1/styleguide/c++/c++11.html
File styleguide/c++/c++11.html (right):

https://codereview.chromium.org/1450013002/diff/1/styleguide/c++/c++11.html#n...
styleguide/c++/c++11.html:298: <td></td>
Can you put "Note: std::move() is allowed but writing your own move constructors
is still only allowed in exceptional cases for now, see 'Rvalue References (and
Move Semantics)' above" or something to that effect in this last <td>

[Nico, 2015-11-16 18:47:47]

(Oh, and adding a use of std::move() like Dana said is an excellent idea
too.)

On Mon, Nov 16, 2015 at 10:47 AM, <thakis@chromium.org> wrote:

> Thanks. lgtm given that lots of stuff is blocked on this.
>
>
> https://codereview.chromium.org/1450013002/diff/1/styleguide/c++/c++11.html
> File styleguide/c++/c++11.html (right):
>
>
>
https://codereview.chromium.org/1450013002/diff/1/styleguide/c++/c++11.html#n...
> styleguide/c++/c++11.html:298: <td></td>
> Can you put "Note: std::move() is allowed but writing your own move
> constructors is still only allowed in exceptional cases for now, see
> 'Rvalue References (and Move Semantics)' above" or something to that
> effect in this last <td>
>
> https://codereview.chromium.org/1450013002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[vmpstr, 2015-11-16 18:56:09]

Added a note, and move usage. PTAL.

[Nico, 2015-11-16 18:57:53]

lgtm with green bots. thanks!

[Nico, 2015-11-16 19:08:14]

https://codereview.chromium.org/1450013002/diff/60001/styleguide/c++/c++11.html
File styleguide/c++/c++11.html (right):

https://codereview.chromium.org/1450013002/diff/60001/styleguide/c++/c++11.ht...
styleguide/c++/c++11.html:298: <td>Note: std::move() is allowed but writing your
own move constructors is still only allowed in exceptional cases for now, see
'Rvalue References (and Move Semantics)'</td>
Oh, and can you also add a link to the discussion thread like all other approved
things have?

[vmpstr, 2015-11-16 19:18:33]

https://codereview.chromium.org/1450013002/diff/60001/styleguide/c++/c++11.html
File styleguide/c++/c++11.html (right):

https://codereview.chromium.org/1450013002/diff/60001/styleguide/c++/c++11.ht...
styleguide/c++/c++11.html:298: <td>Note: std::move() is allowed but writing your
own move constructors is still only allowed in exceptional cases for now, see
'Rvalue References (and Move Semantics)'</td>
On 2015/11/16 19:08:14, Nico wrote:
> Oh, and can you also add a link to the discussion thread like all other
approved
> things have?

Done.

[Nico, 2015-11-16 19:20:49]

thanks! sorry about the piecemeal comments.

[vmpstr, 2015-11-16 19:29:43]

On 2015/11/16 19:20:49, Nico wrote:
> thanks! sorry about the piecemeal comments.

No worries :)

[vmpstr, 2015-11-16 20:04:03]

The CQ bit was checked by vmpstr@chromium.org

[vmpstr, 2015-11-16 20:04:03]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1450013002/#ps80001
(title: "Added discussion thread link")

[commit-bot: I haz the power, 2015-11-16 20:05:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1450013002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1450013002/80001

[commit-bot: I haz the power, 2015-11-16 23:10:44]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-11-16 23:11:23]

Patchset 5 (id:??) landed as
https://crrev.com/f484f72276dc024e5aa15cc6901f0440ee6d7c43
Cr-Commit-Position: refs/heads/master@{#359949}