Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: native_client_sdk/src/build_tools/build_app.py

Issue 14500010: [NaCl SDK] Google Drive example (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove key from build_app generated manifest Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | native_client_sdk/src/build_tools/generate_make.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: native_client_sdk/src/build_tools/build_app.py
diff --git a/native_client_sdk/src/build_tools/build_app.py b/native_client_sdk/src/build_tools/build_app.py
index 50fa5b5254ab06b2ae1fb5ade7dad7f141bd8f8c..1f1b46df875bb2d5b8b54a6c6b6b9a44c0797515 100755
--- a/native_client_sdk/src/build_tools/build_app.py
+++ b/native_client_sdk/src/build_tools/build_app.py
@@ -104,16 +104,17 @@ def main(args):
toolchains=toolchains, configs=[config],
first_toolchain=True)
+ # Collect permissions from each example, and aggregate them.
+ all_permissions = []
+ for _, project in parse_dsc.GenerateProjects(tree):
+ all_permissions.extend(project.get('PERMISSIONS', []))
+
template_dict = {
'name': 'Native Client SDK',
'description':
'Native Client SDK examples, showing API use and key concepts.',
- # TODO(binji): generate list of permissions from examples' DSC files.
- 'permissions': [
- 'fullscreen',
- 'pointerLock',
- 'unlimitedStorage',
- ],
+ 'key': False, # manifests with "key" are rejected when uploading to CWS.
+ 'permissions': all_permissions,
'version': build_utils.ChromeVersionNoTrunk()
}
easy_template.RunTemplateFile(
« no previous file with comments | « no previous file | native_client_sdk/src/build_tools/generate_make.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698