Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Unified Diff: third_party/WebKit/Source/modules/compositorworker/CompositorWorkerManager.cpp

Issue 1449953002: compositor-worker: Refactor CompositorWorkerManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add documentation and ASSERTS for some subtleties. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/compositorworker/CompositorWorkerManager.cpp
diff --git a/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerManager.cpp b/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerManager.cpp
deleted file mode 100644
index d450d29458b1e7867eff5f8903ffe970cfaca4ec..0000000000000000000000000000000000000000
--- a/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerManager.cpp
+++ /dev/null
@@ -1,152 +0,0 @@
-// Copyright 2015 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "config.h"
-#include "modules/compositorworker/CompositorWorkerManager.h"
-
-#include "bindings/core/v8/V8Binding.h"
-#include "bindings/core/v8/V8GCController.h"
-#include "bindings/core/v8/V8Initializer.h"
-#include "bindings/core/v8/V8PerIsolateData.h"
-#include "platform/ThreadSafeFunctional.h"
-#include "platform/WebThreadSupportingGC.h"
-#include "wtf/MainThread.h"
-#include "wtf/ThreadingPrimitives.h"
-
-namespace blink {
-
-namespace {
-
-static CompositorWorkerManager* s_instance = nullptr;
-
-Mutex& singletonMutex()
-{
- AtomicallyInitializedStaticReference(Mutex, mutex, new Mutex);
- return mutex;
-}
-
-void destroyThread(WebThread* thread)
-{
- delete thread;
-}
-
-} // namespace
-
-void CompositorWorkerManager::initialize()
-{
- MutexLocker lock(singletonMutex());
- ASSERT(!s_instance);
- s_instance = new CompositorWorkerManager();
-}
-
-void CompositorWorkerManager::shutdown()
-{
- MutexLocker lock(singletonMutex());
- ASSERT(s_instance);
- delete s_instance;
- s_instance = nullptr;
-}
-
-CompositorWorkerManager* CompositorWorkerManager::instance()
-{
- MutexLocker lock(singletonMutex());
- ASSERT(s_instance);
- return s_instance;
-}
-
-CompositorWorkerManager::CompositorWorkerManager()
-{
-}
-
-CompositorWorkerManager::~CompositorWorkerManager()
-{
-}
-
-WebThreadSupportingGC& CompositorWorkerManager::compositorWorkerThread()
-{
- MutexLocker lock(m_mutex);
- if (!m_thread) {
- ASSERT(isMainThread());
- ASSERT(!m_workerCount);
- // TODO(sadrul): Instead of creating a new thread, retrieve the thread from
- // Platform using a more specialized function
- // (e.g. Platform::compositorWorkerThread()).
- m_platformThread = adoptPtr(Platform::current()->createThread("CompositorWorker Thread"));
- m_thread = WebThreadSupportingGC::createForThread(m_platformThread.get());
- }
- return *m_thread.get();
-}
-
-void CompositorWorkerManager::initializeBackingThread()
-{
- ASSERT(m_thread->isCurrentThread());
- MutexLocker lock(m_mutex);
- ++m_workerCount;
- if (m_workerCount > 1)
- return;
-
- m_thread->initialize();
-
- // Initialize the isolate at the same time.
- ASSERT(!m_isolate);
- m_isolate = V8PerIsolateData::initialize();
- V8Initializer::initializeWorker(m_isolate);
-
- OwnPtr<V8IsolateInterruptor> interruptor = adoptPtr(new V8IsolateInterruptor(m_isolate));
- ThreadState::current()->addInterruptor(interruptor.release());
- ThreadState::current()->registerTraceDOMWrappers(m_isolate, V8GCController::traceDOMWrappers);
-}
-
-void CompositorWorkerManager::shutdownBackingThread()
-{
- MutexLocker lock(m_mutex);
- ASSERT(m_thread->isCurrentThread());
- ASSERT(m_workerCount > 0);
- --m_workerCount;
- if (m_workerCount == 0) {
- m_thread->shutdown();
- m_thread = nullptr;
- Platform::current()->mainThread()->taskRunner()->postTask(BLINK_FROM_HERE, threadSafeBind(destroyThread, AllowCrossThreadAccess(m_platformThread.leakPtr())));
- }
-}
-
-v8::Isolate* CompositorWorkerManager::initializeIsolate()
-{
- MutexLocker lock(m_mutex);
- ASSERT(m_thread->isCurrentThread());
- ASSERT(m_isolate);
- // It is safe to use the existing isolate even if TerminateExecution() has been
- // called on it, without calling CancelTerminateExecution().
- return m_isolate;
-}
-
-void CompositorWorkerManager::willDestroyIsolate()
-{
- MutexLocker lock(m_mutex);
- ASSERT(m_thread->isCurrentThread());
- if (m_workerCount == 1)
- V8PerIsolateData::willBeDestroyed(m_isolate);
-}
-
-void CompositorWorkerManager::destroyIsolate()
-{
- MutexLocker lock(m_mutex);
- if (!m_thread) {
- ASSERT(m_workerCount == 0);
- V8PerIsolateData::destroy(m_isolate);
- m_isolate = nullptr;
- }
-}
-
-void CompositorWorkerManager::terminateV8Execution()
-{
- MutexLocker lock(m_mutex);
- ASSERT(isMainThread());
- if (m_workerCount > 1)
- return;
-
- v8::V8::TerminateExecution(m_isolate);
-}
-
-} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698