content/renderer/render_thread_impl.h - Issue 1449953002: compositor-worker: Refactor CompositorWorkerManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_thread_impl.h

Issue 1449953002: compositor-worker: Refactor CompositorWorkerManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address reviewer comments. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/render_thread_impl.h

diff --git a/content/renderer/render_thread_impl.h b/content/renderer/render_thread_impl.h

index ad108dcd50f2bd88b6b0850b3a13494dcfa24f03..f2a0928f213095c0e3133221f0a3aee670a45c20 100644

--- a/content/renderer/render_thread_impl.h

+++ b/content/renderer/render_thread_impl.h

@@ -45,6 +45,7 @@ class WebGamepads;

class WebGraphicsContext3D;

class WebMediaStreamCenter;

class WebMediaStreamCenterClient;

+class WebThread;

}

namespace base {

@@ -588,7 +589,7 @@ class CONTENT_EXPORT RenderThreadImpl

scoped_ptr<base::Thread> file_thread_;

// May be null if overridden by ContentRendererClient.

- scoped_ptr<base::Thread> compositor_thread_;

+ scoped_ptr<blink::WebThread> compositor_thread_;

piman 2015/11/30 21:41:45 nit: make this the concrete type to avoid static_c

Ian Vollick 2015/12/01 04:00:04 Done.

// Utility class to provide GPU functionalities to media.

scoped_ptr<content::RendererGpuVideoAcceleratorFactories> gpu_factories_;

« content/child/blink_platform_impl.cc ('K') | « content/child/blink_platform_impl.cc ('k') | content/renderer/render_thread_impl.cc » ('j') | no next file with comments »