components/scheduler/child/webthread_impl_for_worker_scheduler.cc - Issue 1449953002: compositor-worker: Refactor CompositorWorkerManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/scheduler/child/webthread_impl_for_worker_scheduler.cc

Issue 1449953002: compositor-worker: Refactor CompositorWorkerManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address reviewer comments. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/scheduler/child/webthread_impl_for_worker_scheduler.h ('k') | content/child/blink_platform_impl.h » ('j') | content/child/blink_platform_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/scheduler/child/webthread_impl_for_worker_scheduler.cc

diff --git a/components/scheduler/child/webthread_impl_for_worker_scheduler.cc b/components/scheduler/child/webthread_impl_for_worker_scheduler.cc

index 8cd69b80d0d7d7a760d869b2e17ef2a29db60e2f..abe0d554099c80e1019c346a381ec1fa08037f36 100644

--- a/components/scheduler/child/webthread_impl_for_worker_scheduler.cc

+++ b/components/scheduler/child/webthread_impl_for_worker_scheduler.cc

@@ -20,8 +20,13 @@ namespace scheduler {

WebThreadImplForWorkerScheduler::WebThreadImplForWorkerScheduler(

const char* name)

- : thread_(new base::Thread(name)) {

- thread_->Start();

+ : WebThreadImplForWorkerScheduler(name, base::Thread::Options()) {}

+WebThreadImplForWorkerScheduler::WebThreadImplForWorkerScheduler(

+ const char* name,

+ base::Thread::Options options)

+ : thread_(new base::Thread(name ? name : "")) {

piman 2015/11/30 21:41:45 nit: std::string() instead of "" to avoid a needle

Ian Vollick 2015/12/01 04:00:03 Done.

+ thread_->StartWithOptions(options);

thread_task_runner_ = thread_->task_runner();

base::WaitableEvent completion(false, false);