compositor-worker: Refactor CompositorWorkerManager

components/scheduler/child/webthread_impl_for_worker_scheduler.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/scheduler/child/webthread_impl_for_worker_scheduler.h"
 
 #include "base/bind.h"
 #include "base/location.h"
 #include "base/single_thread_task_runner.h"
 #include "base/synchronization/waitable_event.h"
 #include "base/time/default_tick_clock.h"
 #include "components/scheduler/base/task_queue.h"
 #include "components/scheduler/child/scheduler_tqm_delegate_impl.h"
 #include "components/scheduler/child/web_scheduler_impl.h"
 #include "components/scheduler/child/web_task_runner_impl.h"
 #include "components/scheduler/child/worker_scheduler_impl.h"
 #include "third_party/WebKit/public/platform/WebTraceLocation.h"
 
 namespace scheduler {
 
 WebThreadImplForWorkerScheduler::WebThreadImplForWorkerScheduler(
     const char* name)
-    : thread_(new base::Thread(name)) {
-  thread_->Start();
+    : WebThreadImplForWorkerScheduler(name, base::Thread::Options()) {}
+
+WebThreadImplForWorkerScheduler::WebThreadImplForWorkerScheduler(
+    const char* name,
+    base::Thread::Options options)
+    : thread_(new base::Thread(name ? name : "")) {

[piman, 2015/11/30 21:41:45]

nit: std::string() instead of "" to avoid a needless copy.

[Ian Vollick, 2015/12/01 04:00:03]

Done.

+  thread_->StartWithOptions(options);
   thread_task_runner_ = thread_->task_runner();
 
   base::WaitableEvent completion(false, false);
   thread_task_runner_->PostTask(
       FROM_HERE, base::Bind(&WebThreadImplForWorkerScheduler::InitOnThread,
                             base::Unretained(this), &completion));
   completion.Wait();
 }
 
 WebThreadImplForWorkerScheduler::~WebThreadImplForWorkerScheduler() {
@@ skipping 65 matching lines @@
     base::MessageLoop::TaskObserver* observer) {
   worker_scheduler_->AddTaskObserver(observer);
 }
 
 void WebThreadImplForWorkerScheduler::RemoveTaskObserverInternal(
     base::MessageLoop::TaskObserver* observer) {
   worker_scheduler_->RemoveTaskObserver(observer);
 }
 
 }  // namespace scheduler